From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Wolfgang Steinwender <wsteinwender@pcs.com>,
<netdev@vger.kernel.org>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors
Date: Fri, 10 Apr 2015 16:12:10 +0200 [thread overview]
Message-ID: <5527DA3A.6030105@atmel.com> (raw)
In-Reply-To: <1428658976-28050-1-git-send-email-wsteinwender@pcs.com>
Le 10/04/2015 11:42, Wolfgang Steinwender a écrit :
> The statistics are grouped by TX and RX errors.
> The SQE Test Errors Register indicates problems with TX.
>
> Signed-off-by: Wolfgang Steinwender <wsteinwender@pcs.com>
seems okay:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/net/ethernet/cadence/macb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 448a323..9f53872 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1956,12 +1956,12 @@ static struct net_device_stats *macb_get_stats(struct net_device *dev)
> hwstat->rx_oversize_pkts +
> hwstat->rx_jabbers +
> hwstat->rx_undersize_pkts +
> - hwstat->sqe_test_errors +
> hwstat->rx_length_mismatch);
> nstat->tx_errors = (hwstat->tx_late_cols +
> hwstat->tx_excessive_cols +
> hwstat->tx_underruns +
> - hwstat->tx_carrier_errors);
> + hwstat->tx_carrier_errors +
> + hwstat->sqe_test_errors);
> nstat->collisions = (hwstat->tx_single_cols +
> hwstat->tx_multiple_cols +
> hwstat->tx_excessive_cols);
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-04-10 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 9:42 [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors Wolfgang Steinwender
2015-04-10 14:12 ` Nicolas Ferre [this message]
2015-04-13 0:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5527DA3A.6030105@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wsteinwender@pcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.