From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ygazs-0005IU-Rz for qemu-devel@nongnu.org; Fri, 10 Apr 2015 11:37:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ygazo-0002Zs-4z for qemu-devel@nongnu.org; Fri, 10 Apr 2015 11:37:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ygazn-0002Zm-SJ for qemu-devel@nongnu.org; Fri, 10 Apr 2015 11:37:28 -0400 Message-ID: <5527EE2D.5040502@redhat.com> Date: Fri, 10 Apr 2015 09:37:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <22addebd05899a031834f63dbfe4358c5d38ac9e.1427954659.git.zhugh.fnst@cn.fujitsu.com> In-Reply-To: <22addebd05899a031834f63dbfe4358c5d38ac9e.1427954659.git.zhugh.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua , qemu-devel@nongnu.org, imammedo@redhat.com, mst@redhat.com, pbonzini@redhat.com Cc: guz.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, tangchen@cn.fujitsu.com On 04/02/2015 03:50 AM, Zhu Guihua wrote: > When memory hot unplug fails, this patch adds support to send > QMP event to notify mgmt about this failure. > > Signed-off-by: Zhu Guihua > --- > docs/qmp/qmp-events.txt | 17 +++++++++++++++++ > hw/acpi/memory_hotplug.c | 10 +++++++++- > monitor.c | 1 + > qapi/event.json | 14 ++++++++++++++ > trace-events | 1 + > 5 files changed, 42 insertions(+), 1 deletion(-) > > +++ b/monitor.c > @@ -587,6 +587,7 @@ static void monitor_qapi_event_init(void) > monitor_qapi_event_throttle(QAPI_EVENT_QUORUM_REPORT_BAD, 1000); > monitor_qapi_event_throttle(QAPI_EVENT_QUORUM_FAILURE, 1000); > monitor_qapi_event_throttle(QAPI_EVENT_VSERPORT_CHANGE, 1000); > + monitor_qapi_event_throttle(QAPI_EVENT_MEM_UNPLUG_ERROR, 1000); Is this event triggerable under guest control, or only under management control? We MUST throttle events that the guest can trigger, but it makes no sense to trigger something that can only happen under host control. > +++ b/qapi/event.json > @@ -330,3 +330,17 @@ > ## > { 'event': 'VSERPORT_CHANGE', > 'data': { 'id': 'str', 'open': 'bool' } } > + > +## > +# @MEM_UNPLUG_ERROR > +# > +# Emitted when memory hot unplug error occurs. > +# > +# @device: device name > +# > +# @msg: Informative message Any reason you abbreviated instead of spelling it out as 'message'? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org