From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhDQH-0002HM-Ns for qemu-devel@nongnu.org; Sun, 12 Apr 2015 04:39:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhDQE-00009q-IU for qemu-devel@nongnu.org; Sun, 12 Apr 2015 04:39:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54951 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhDQE-00009e-Bl for qemu-devel@nongnu.org; Sun, 12 Apr 2015 04:39:18 -0400 Message-ID: <552A2F33.7080108@suse.de> Date: Sun, 12 Apr 2015 10:39:15 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1428777292-24628-1-git-send-email-afaerber@suse.de> <1428777292-24628-8-git-send-email-afaerber@suse.de> <552983D8.70904@suse.de> <55299647.10303@suse.de> <263F0FD9-0CC8-428D-A72D-B119ED3D983F@suse.de> In-Reply-To: <263F0FD9-0CC8-428D-A72D-B119ED3D983F@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Peter Maydell , QEMU Developers , Richard Henderson Am 12.04.2015 um 10:34 schrieb Alexander Graf: >> Am 11.04.2015 um 23:46 schrieb Andreas F=C3=A4rber : >> >>> Am 11.04.2015 um 23:33 schrieb Peter Maydell: >>>> On 11 April 2015 at 21:28, Andreas F=C3=A4rber wr= ote: >>>> Are you sure that QEMU / runcom / pi_10.com still try to map to that >>>> address zero? >>> >>> It's the first thing runcom.c's main() does after checking you've >>> passed it enough command line arguments. >> >> This? >> >> vm86_mem =3D mmap((void *)0x00000000, 0x110000, >> PROT_WRITE | PROT_READ | PROT_EXEC, >> MAP_FIXED | MAP_ANON | MAP_PRIVATE, -1, 0); >> if (vm86_mem =3D=3D MAP_FAILED) { >> perror("mmap"); >> exit(1); >> } >> >> For whatever reason it does not take the MAP_FAILED path here... >=20 > Wasn't a NULL argument for the address a hint saying "map wherever you = please"? I also feel like I'm missing context here - what exactly is brok= en? Sorry for CC'ing you so late, I believe you and rth had been fiddling with guest bases and that stuff back in the day... Please just take a look at the whole series, in particular patches 3 and 7. Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)