From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhTcS-00052C-OA for qemu-devel@nongnu.org; Sun, 12 Apr 2015 21:57:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhTcP-0006zh-IK for qemu-devel@nongnu.org; Sun, 12 Apr 2015 21:57:00 -0400 Received: from [59.151.112.132] (port=35900 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhTcP-0006y5-5q for qemu-devel@nongnu.org; Sun, 12 Apr 2015 21:56:57 -0400 Message-ID: <552B2247.70104@cn.fujitsu.com> Date: Mon, 13 Apr 2015 09:56:23 +0800 From: Zhu Guihua MIME-Version: 1.0 References: <22addebd05899a031834f63dbfe4358c5d38ac9e.1427954659.git.zhugh.fnst@cn.fujitsu.com> <5527EE2D.5040502@redhat.com> In-Reply-To: <5527EE2D.5040502@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org, imammedo@redhat.com, mst@redhat.com, pbonzini@redhat.com Cc: guz.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, tangchen@cn.fujitsu.com On 04/10/2015 11:37 PM, Eric Blake wrote: > On 04/02/2015 03:50 AM, Zhu Guihua wrote: >> When memory hot unplug fails, this patch adds support to send >> QMP event to notify mgmt about this failure. >> >> Signed-off-by: Zhu Guihua >> --- >> docs/qmp/qmp-events.txt | 17 +++++++++++++++++ >> hw/acpi/memory_hotplug.c | 10 +++++++++- >> monitor.c | 1 + >> qapi/event.json | 14 ++++++++++++++ >> trace-events | 1 + >> 5 files changed, 42 insertions(+), 1 deletion(-) >> >> +++ b/monitor.c >> @@ -587,6 +587,7 @@ static void monitor_qapi_event_init(void) >> monitor_qapi_event_throttle(QAPI_EVENT_QUORUM_REPORT_BAD, 1000); >> monitor_qapi_event_throttle(QAPI_EVENT_QUORUM_FAILURE, 1000); >> monitor_qapi_event_throttle(QAPI_EVENT_VSERPORT_CHANGE, 1000); >> + monitor_qapi_event_throttle(QAPI_EVENT_MEM_UNPLUG_ERROR, 1000); > Is this event triggerable under guest control, or only under management > control? We MUST throttle events that the guest can trigger, but it > makes no sense to trigger something that can only happen under host control. It's under management control, this event should not be throttled, it's my mistake and I will delete this. Thanks. > >> +++ b/qapi/event.json >> @@ -330,3 +330,17 @@ >> ## >> { 'event': 'VSERPORT_CHANGE', >> 'data': { 'id': 'str', 'open': 'bool' } } >> + >> +## >> +# @MEM_UNPLUG_ERROR >> +# >> +# Emitted when memory hot unplug error occurs. >> +# >> +# @device: device name >> +# >> +# @msg: Informative message > Any reason you abbreviated instead of spelling it out as 'message'? This only refer to the spelling of event BLOCK_IMAGE_CORRUPTED in docs/qmp/qmp-events.txt. Thanks, Zhu