From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 4/4] hvmloader: add knob for fixed VGABIOS date string Date: Mon, 13 Apr 2015 09:51:26 +0100 Message-ID: <552B9FAE02000078000715BA@mail.emea.novell.com> References: <1427894915-32595-1-git-send-email-olaf@aepfle.de> <1427894915-32595-5-git-send-email-olaf@aepfle.de> <1427967942.4037.29.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427967942.4037.29.camel@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Olaf Hering , xen-devel@lists.xen.org, Wei Liu , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org >>> On 02.04.15 at 11:45, wrote: > On Wed, 2015-04-01 at 13:28 +0000, Olaf Hering wrote: >> To allow reproducible builds of hvmloader introduce a make variable >> VGABIOS_REL_DATE="dd Mon yyyy" to provide a fixed date string. Without >> this change the hvmloader binary changes with every rebuild. >> >> Signed-off-by: Olaf Hering >> Cc: Ian Jackson >> Cc: Stefano Stabellini > > Acked-by: Ian Campbell > > It's not clear if vgabios should be maintained by us tools folks or if > it should have been taken under the hvmloader umbrella and maintained by > the hypervisor folks. I'm not sure either - hvmloader is really code we grew and hence maintaining it together with its hypervisor side makes sense. For the various firmware blobs, otoh, I think they match more closely with the qemu/tools pattern. Jan