From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v3 3/8] x86: detect and initialize Intel CAT feature Date: Mon, 13 Apr 2015 11:51:46 +0100 Message-ID: <552BBBE20200007800071685@mail.emea.novell.com> References: <1427373505-9303-1-git-send-email-chao.p.peng@linux.intel.com> <1427373505-9303-4-git-send-email-chao.p.peng@linux.intel.com> <5515A1EF.8090602@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5515A1EF.8090602@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Chao Peng , xen-devel@lists.xen.org Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, will.auld@intel.com, keir@xen.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org >>> On 27.03.15 at 19:31, wrote: > On 26/03/15 12:38, Chao Peng wrote: >> + cpuid_count(PSR_CPUID_LEVEL_CAT, 0, &eax, &ebx, &ecx, &edx); >> + if ( ebx & PSR_RESOURCE_TYPE_L3 ) >> + { >> + cpuid_count(PSR_CPUID_LEVEL_CAT, 1, &eax, &ebx, &ecx, &edx); >> + info->cbm_len = (eax & 0x1f) + 1; >> + info->cos_max = (edx & 0xffff); >> + >> + info->enabled = 1; >> + printk(XENLOG_DEBUG "CAT: enabled on socket %u, cos_max:%u, cbm_len:%u\n", >> + socket, info->cos_max, info->cbm_len); > > I would bump this to INFO, at least for socket 0. Similar to CMT, a > user which has gone to the effort of enabling CAT will want some > indication in the boot log without also having to bump the logging level. Which INFO wouldn't be sufficient for (at least not with the xen.org defaults, not sure about XenServer's). Jan