From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YhfXD-0001IX-Uj
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:40:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YhfXA-00044V-It
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:40:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YhfXA-00044L-BG
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:40:20 -0400
Message-ID: <552BD544.2030800@redhat.com>
Date: Mon, 13 Apr 2015 08:40:04 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <cover.1427954659.git.zhugh.fnst@cn.fujitsu.com>
	<22addebd05899a031834f63dbfe4358c5d38ac9e.1427954659.git.zhugh.fnst@cn.fujitsu.com>
	<5527EE2D.5040502@redhat.com> <552B2247.70104@cn.fujitsu.com>
In-Reply-To: <552B2247.70104@cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification
 for memory hot unplug error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org, imammedo@redhat.com, mst@redhat.com, pbonzini@redhat.com
Cc: guz.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, tangchen@cn.fujitsu.com

On 04/12/2015 07:56 PM, Zhu Guihua wrote:
> 
> On 04/10/2015 11:37 PM, Eric Blake wrote:
>> On 04/02/2015 03:50 AM, Zhu Guihua wrote:
>>> When memory hot unplug fails, this patch adds support to send
>>> QMP event to notify mgmt about this failure.
>>>
>>> Signed-off-by: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
>>> ---
>>>   docs/qmp/qmp-events.txt  | 17 +++++++++++++++++
>>>   hw/acpi/memory_hotplug.c | 10 +++++++++-
>>>   monitor.c                |  1 +
>>>   qapi/event.json          | 14 ++++++++++++++
>>>   trace-events             |  1 +
>>>   5 files changed, 42 insertions(+), 1 deletion(-)

>>> +##
>>> +# @MEM_UNPLUG_ERROR
>>> +#
>>> +# Emitted when memory hot unplug error occurs.
>>> +#
>>> +# @device: device name
>>> +#
>>> +# @msg: Informative message
>> Any reason you abbreviated instead of spelling it out as 'message'?
> 
> This only refer to the spelling of event BLOCK_IMAGE_CORRUPTED
> in docs/qmp/qmp-events.txt.

Just because existing code abbreviated does not mean that new code needs
to copy the bad example.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org