All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub
Date: Mon, 13 Apr 2015 10:20:38 -0500	[thread overview]
Message-ID: <552BDEC6.30509@opensource.altera.com> (raw)
In-Reply-To: <201504111857.40046.marex@denx.de>

On 04/11/2015 11:57 AM, Marek Vasut wrote:
> On Tuesday, April 07, 2015 at 04:31:43 PM, Dinh Nguyen wrote:
>> On Fri, 3 Apr 2015, Marek Vasut wrote:
>>> On Tuesday, March 31, 2015 at 12:01:11 AM, dinguyen at opensource.altera.com 
> wrote:
>>>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>>>
>>>> Add a stub s_init function in the board file.
>>>
>>> Why do you add this stub function ? The commit message should
>>> clarify why the patch is needed.
>>
>> I get this error without this patch:
>>
>> make: *** [spl/u-boot-spl] Error 2
>> arch/arm/cpu/armv7/built-in.o: In function `lowlevel_init':
>> /home/dinguyen/linux_dev/uboot-socfpga/arch/arm/cpu/armv7/lowlevel_init.S:5
>> 7: undefined reference to `s_init'
>>
>> I got the idea that I needed to add this function from this commit
>> "24a6bc010 arm: Reduce the scope of lowlevel_init()".
>>
>> Commit "e755d543 spl_atmel.c: Switch s_init to board_init_f" is alluding
>> that lowlevel_init is morphing into s_init(), so for now, a stub s_init is
>> needed?
> 
> Ah right. Sorry for the noise.

No worries, I should have been more descriptive in my commit message.
Will try to be in future revisions.

Dinh

  reply	other threads:[~2015-04-13 15:20 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 22:01 [U-Boot] [PATCHv3 00/17] Add SPL support for SoCFPGA dinguyen at opensource.altera.com
2015-03-30 22:01 ` [U-Boot] [PATCHv3 01/17] arm: socfpga: spl: Add main sdram code dinguyen at opensource.altera.com
2015-03-31  6:41   ` Wolfgang Denk
2015-04-03  2:00     ` Marek Vasut
2015-04-03  4:55       ` Dinh Nguyen
2015-04-03 23:31         ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 02/17] arm: socfpga: spl: Add CONFIG_SPL_MAX_SIZE to be 64KB dinguyen at opensource.altera.com
2015-04-03  1:44   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 03/17] arm: socfpga: add functions to bring sdram, timer, and uart out of reset dinguyen at opensource.altera.com
2015-04-03  1:45   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 04/17] arm: socfpga: spl: enable sdram, timer and uart dinguyen at opensource.altera.com
2015-04-03  1:45   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 05/17] arm: socfpga: spl: Add call to timer_init dinguyen at opensource.altera.com
2015-04-03  1:45   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 06/17] arm: socfpga: spl: allow bootrom to enable IOs after warm reset dinguyen at opensource.altera.com
2015-04-03  1:46   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 07/17] arm: socfpga: spl: add sdram init and calibration dinguyen at opensource.altera.com
2015-03-31 21:00   ` Pavel Machek
2015-04-03  1:47     ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 08/17] arm: socfpga: spl: printout sdram size dinguyen at opensource.altera.com
2015-04-03  1:47   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 09/17] arm: socfpga: spl: Use common lowlevel_init dinguyen at opensource.altera.com
2015-04-03  1:48   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub dinguyen at opensource.altera.com
2015-04-03  1:49   ` Marek Vasut
2015-04-07 14:31     ` Dinh Nguyen
2015-04-11 16:57       ` Marek Vasut
2015-04-13 15:20         ` Dinh Nguyen [this message]
2015-04-13 15:33           ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 11/17] arm: socfpga: spl: add CONFIG_SPL_STACK to socfpga_common.h dinguyen at opensource.altera.com
2015-04-03  1:50   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 12/17] arm: socfpga: spl: Adjust the SYS_INIT_RAM_SIZE to have room for the spl malloc dinguyen at opensource.altera.com
2015-04-03  1:51   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 13/17] arm: socfpga: spl: add board_init_f to SPL dinguyen at opensource.altera.com
2015-03-31 21:07   ` Pavel Machek
2015-04-03  1:52     ` Marek Vasut
2015-04-07 14:34       ` Dinh Nguyen
2015-04-11 16:57         ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 14/17] arm: socfpga: spl: Add SDRAM check dinguyen at opensource.altera.com
2015-03-31 21:11   ` Pavel Machek
2015-04-03  1:53     ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 15/17] arm: socfpga: spl: update pll_config for dev kit dinguyen at opensource.altera.com
2015-04-03  1:54   ` Marek Vasut
2015-04-15 20:49     ` Dinh Nguyen
2015-04-16  6:24       ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 16/17] arm: socfpga: remove the need to map sdram in arch_early_init dinguyen at opensource.altera.com
2015-03-31 21:13   ` Pavel Machek
2015-04-03  1:55   ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 17/17] arm: socfpga: fix uart0 pin mux configuration dinguyen at opensource.altera.com
2015-03-31 20:48   ` Pavel Machek
2015-03-31 20:59     ` Dinh Nguyen
2015-03-31 21:13       ` Pavel Machek
2015-04-03  1:57         ` Marek Vasut
2015-04-03  1:56   ` Marek Vasut
2015-03-31 21:14 ` [U-Boot] [PATCHv3 00/17] Add SPL support for SoCFPGA Pavel Machek
2015-04-06 14:40 ` [U-Boot] printf("%d") breaks u-boot 2015.01+ Pavel Machek
2015-04-06 14:59   ` Marek Vasut
2015-04-06 18:14     ` Pavel Machek
2015-04-06 18:48       ` Marek Vasut
2015-04-06 19:23         ` Pavel Machek
2015-04-06 21:02           ` Marek Vasut
2015-04-07  7:53             ` Pavel Machek
2015-04-07 12:23     ` [U-Boot] u-boot 2015.04 on socfpga was " Pavel Machek
2015-04-07  5:13   ` [U-Boot] " Heiko Schocher
2015-04-07  7:56     ` Pavel Machek
2015-04-07  8:16       ` Heiko Schocher
2015-04-08 12:09         ` Pavel Machek
2015-04-08 13:13           ` Marek Vasut
2015-04-08 14:00             ` Pavel Machek
2015-04-13 11:12             ` [U-Boot] "socfpga sdram_applycfg" in mainline u-boot Pavel Machek
2015-04-13 11:24               ` Marek Vasut
2015-04-13 11:29                 ` Stefan Roese
2015-04-08 13:49           ` [U-Boot] printf("%d") breaks u-boot 2015.01+ Tom Rini
2015-04-08 14:06             ` Pavel Machek
2015-04-08 15:53               ` Tom Rini
2015-04-08 16:06                 ` Pavel Machek
2015-04-08 16:43                   ` Tom Rini
2015-04-08 16:08                 ` Tom Rini
2015-04-13 12:45                   ` Pavel Machek
2015-04-13 12:49                   ` [U-Boot] [patch] break build if it would produce broken binary Pavel Machek
2015-04-13 12:52                     ` Tom Rini
2015-04-13 20:38                       ` Pavel Machek
2015-06-02 17:11                         ` Simon Glass
2015-08-13 15:06                           ` Pavel Machek
2015-08-13 17:41                             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552BDEC6.30509@opensource.altera.com \
    --to=dinguyen@opensource.altera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.