From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932841AbbDMPuZ (ORCPT ); Mon, 13 Apr 2015 11:50:25 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:36741 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932735AbbDMPuT (ORCPT ); Mon, 13 Apr 2015 11:50:19 -0400 Message-ID: <552BE5B8.4050204@hurleysoftware.com> Date: Mon, 13 Apr 2015 11:50:16 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu CC: Arnd Bergmann , stable@vger.kernel.org, Greg Kroah-Hartman , linux-serial@vger.kernel.org, Jiri Slaby , Arnd Bergmann Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ + Arnd ] Hi Michal, On 04/13/2015 10:35 AM, Michal Simek wrote: > Do not probe all serial drivers by of_serial.c which are using > device_type = "serial"; property. Only drivers which have valid > compatible strings listed in the driver should be probed. What does this fix? Is there some kind of probe problem you're trying to address? Are you trying to silence the error message? > When PORT_UNKNOWN probe will fail anyway. Ok, but doesn't device_attach() just continue to try to match other drivers on the platform bus? Regards, Peter Hurley > Signed-off-by: Michal Simek > CC: > --- > > drivers/tty/serial/of_serial.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c > index 33fb94f78967..0a52c8b55a5f 100644 > --- a/drivers/tty/serial/of_serial.c > +++ b/drivers/tty/serial/of_serial.c > @@ -344,7 +344,6 @@ static struct of_device_id of_platform_serial_table[] = { > { .compatible = "ibm,qpace-nwp-serial", > .data = (void *)PORT_NWPSERIAL, }, > #endif > - { .type = "serial", .data = (void *)PORT_UNKNOWN, }, > { /* end of list */ }, > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration Date: Mon, 13 Apr 2015 11:50:16 -0400 Message-ID: <552BE5B8.4050204@hurleysoftware.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: stable-owner@vger.kernel.org To: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu Cc: Arnd Bergmann , stable@vger.kernel.org, Greg Kroah-Hartman , linux-serial@vger.kernel.org, Jiri Slaby Arnd Bergmann List-Id: linux-serial@vger.kernel.org [ + Arnd ] Hi Michal, On 04/13/2015 10:35 AM, Michal Simek wrote: > Do not probe all serial drivers by of_serial.c which are using > device_type = "serial"; property. Only drivers which have valid > compatible strings listed in the driver should be probed. What does this fix? Is there some kind of probe problem you're trying to address? Are you trying to silence the error message? > When PORT_UNKNOWN probe will fail anyway. Ok, but doesn't device_attach() just continue to try to match other drivers on the platform bus? Regards, Peter Hurley > Signed-off-by: Michal Simek > CC: > --- > > drivers/tty/serial/of_serial.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c > index 33fb94f78967..0a52c8b55a5f 100644 > --- a/drivers/tty/serial/of_serial.c > +++ b/drivers/tty/serial/of_serial.c > @@ -344,7 +344,6 @@ static struct of_device_id of_platform_serial_table[] = { > { .compatible = "ibm,qpace-nwp-serial", > .data = (void *)PORT_NWPSERIAL, }, > #endif > - { .type = "serial", .data = (void *)PORT_UNKNOWN, }, > { /* end of list */ }, > }; > >