From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] tools/libxc: Fix build of 32bit toolstacks on CentOS 5.x following XSA-125 Date: Mon, 13 Apr 2015 17:37:04 +0100 Message-ID: <552BF0B0.90708@citrix.com> References: <1428940983-8709-1-git-send-email-andrew.cooper3@citrix.com> <21803.61424.207722.792094@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21803.61424.207722.792094@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: security@xen.org, Wei Liu , Ian Campbell , Xen-devel List-Id: xen-devel@lists.xenproject.org On 13/04/15 17:33, Ian Jackson wrote: > Andrew Cooper writes ("[Xen-devel] [PATCH] tools/libxc: Fix build of 32bit toolstacks on CentOS 5.x following XSA-125"): >> gcc 4.1 of CentOS 5.x era does not like the typecheck in min() between >> uint64_t and unsigned long. >> >> Signed-off-by: Andrew Cooper >> CC: Konrad Rzeszutek Wilk >> CC: Ian Campbell >> CC: Ian Jackson >> CC: Wei Liu > As and when this is acked and pushed to #staging, we should update the > advisory. > >> This needs backporting to 4.5 > To be clear, do you know whether this is a trivial cherry pick ? It is trivial to cherrypick. 4.4 is the problematic case which I did the backport for separately, but then that is trivial to cherrypick back to 4.2 ~Andrew