From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhuUl-0002Dm-03 for qemu-devel@nongnu.org; Tue, 14 Apr 2015 02:38:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhuUh-0002jP-Hs for qemu-devel@nongnu.org; Tue, 14 Apr 2015 02:38:50 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:22766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhuUg-0002j4-I9 for qemu-devel@nongnu.org; Tue, 14 Apr 2015 02:38:47 -0400 Message-ID: <552CB5DA.4080303@huawei.com> Date: Tue, 14 Apr 2015 14:38:18 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com> <1428055432-12120-17-git-send-email-zhaoshenglong@huawei.com> <87sic4ja5a.fsf@linaro.org> <20150414075457-mutt-send-email-mst@redhat.com> In-Reply-To: <20150414075457-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 16/20] hw/acpi/aml-build: Add aml_else() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , =?ISO-8859-1?Q?Alex_Benn=E9e?= Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, pbonzini@redhat.com, hanjun.guo@linaro.org, msalter@redhat.com, imammedo@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On 2015/4/14 13:56, Michael S. Tsirkin wrote: > On Mon, Apr 13, 2015 at 04:55:13PM +0100, Alex Bennée wrote: >> >> Shannon Zhao writes: >> >>> From: Shannon Zhao >>> >>> Signed-off-by: Shannon Zhao >>> Signed-off-by: Shannon Zhao >> >> I was considering if the magic numbers should be defined somewhere but I >> guess that is the point of the stub functions. > > I don't think so: wrappers make sure each is used > only once. enums would just obfuscate code. > comments are better in that they match the language > used in the acpi spec, exactly. > I think this has nothing to do with the Opcode used once or other. Maybe the Opcodes should be defined at one place, then have a whole scope of the Opcodes and drop the magic numbers. >> Reviewed-by: Alex Bennée > >> >>> --- >>> hw/acpi/aml-build.c | 7 +++++++ >>> include/hw/acpi/aml-build.h | 1 + >>> 2 files changed, 8 insertions(+) >>> >>> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >>> index 4f936f7..9b8b422 100644 >>> --- a/hw/acpi/aml-build.c >>> +++ b/hw/acpi/aml-build.c >>> @@ -626,6 +626,13 @@ Aml *aml_if(Aml *predicate) >>> return var; >>> } >>> >>> +/* ACPI 1.0: 16.2.3 Operators: DefElse */ >>> +Aml *aml_else(void) >>> +{ >>> + Aml *var = aml_bundle(0xA1 /* ElseOp */, AML_PACKAGE); >>> + return var; >>> +} >>> + >>> /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMethod */ >>> Aml *aml_method(const char *name, int arg_count) >>> { >>> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h >>> index 6b407d5..3901515 100644 >>> --- a/include/hw/acpi/aml-build.h >>> +++ b/include/hw/acpi/aml-build.h >>> @@ -206,6 +206,7 @@ Aml *aml_scope(const char *name_format, ...) GCC_FMT_ATTR(1, 2); >>> Aml *aml_device(const char *name_format, ...) GCC_FMT_ATTR(1, 2); >>> Aml *aml_method(const char *name, int arg_count); >>> Aml *aml_if(Aml *predicate); >>> +Aml *aml_else(void); >>> Aml *aml_package(uint8_t num_elements); >>> Aml *aml_buffer(void); >>> Aml *aml_resource_template(void); >> >> -- >> Alex Bennée > > > . >