From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36935)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YhxrY-0001d4-WD
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 06:14:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YhxrU-0003aO-5l
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 06:14:36 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:41682)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YhxrT-0003ZU-JS
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 06:14:32 -0400
Message-ID: <552CE864.9040407@huawei.com>
Date: Tue, 14 Apr 2015 18:13:56 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com>
	<1428055432-12120-20-git-send-email-zhaoshenglong@huawei.com>
	<87mw2cj9zi.fsf@linaro.org> <552C691D.3090702@huawei.com>
	<CAFEAcA9wjjCCBVzAJuB945qKQXsShKn-Lu4R8ExYKg1Ga3-j2w@mail.gmail.com>
	<552CE41B.2070501@huawei.com>
	<20150414115900-mutt-send-email-mst@redhat.com>
In-Reply-To: <20150414115900-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe
 controller in ACPI DSDT table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, hangaohuai@huawei.com, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, Mark Salter <msalter@redhat.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Laszlo Ersek <lersek@redhat.com>, Hanjun Guo <hanjun.guo@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, =?ISO-8859-1?Q?Alex_Benn=E9?= =?ISO-8859-1?Q?e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 2015/4/14 17:59, Michael S. Tsirkin wrote:
> On Tue, Apr 14, 2015 at 05:55:39PM +0800, Shannon Zhao wrote:
>> On 2015/4/14 17:30, Peter Maydell wrote:
>>> On 14 April 2015 at 02:10, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>>>> On 2015/4/13 23:58, Alex Bennée wrote:
>>>>>
>>>>> Shannon Zhao <zhaoshenglong@huawei.com> writes:
>>>>>> +    UUID = aml_touuid(0x33DB4D5B, 0x1FF7, 0x401C, 0x9657,
>>>>>> 0x7441C03DD766);
>>>>>
>>>>> This looks like a fairly unreadable uuid already. What are these magic numbers?
>>>>>
>>>>
>>>> Yes, this will be modified to use string according to the spec. Like below way:
>>>>
>>>> UUID = aml_touuid("33DB4D5B-1FF7-401C-9657-7441C03DD766");
>>>
>>> Those are still magic numbers, you've  just put them into
>>> a different format. Where do they come from? What do they mean?
>>>
>>
>> This is from the PCI Firmware Spec.
>>
>> "The _OSC interface for a PCI/PCI-X/PCI Express hierarchy is identified by the Universal Unique
>> IDentifier (UUID) 33db4d5b-1ff7-401c-9657-7441c03dd766."
>>
>> "The UUID in _DSM in this context is {E5C937D0-3553-4d7a-9117-EA4D19C3434D}"
>>
>> Maybe I should use a macro definition for them.
> 
> If there's a single instance of use, a comment would
> do as well.
> 

Ok, will add.

-- 
Thanks,
Shannon