From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Tue, 14 Apr 2015 12:50:09 +0200 Subject: [Buildroot] [git commit] fs: add rootfs dependencies to PACKAGES In-Reply-To: <20150414081954.EF1607F9E1@busybox.osuosl.org> References: <20150414081954.EF1607F9E1@busybox.osuosl.org> Message-ID: <552CF0E1.5090205@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 14/04/15 10:17, Thomas Petazzoni wrote: > commit: http://git.buildroot.net/buildroot/commit/?id=4570dbcb14b394d8f3c97baf4c9e5f4f225d1d37 > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master > > The logic for creating most of the filesystem images requires a > certain number of host packages to be built. However, those packages > are not currently listed in the global PACKAGES variables, and they > are not dependencies of any other package listed in the PACKAGES > variable. > > While it does not have any practical implications, it makes sense to > have those packages listed in the global PACKAGES variable, which this > commit implements. > > Signed-off-by: Thomas Petazzoni > Acked-by: "Yann E. MORIN" > --- > fs/common.mk | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/fs/common.mk b/fs/common.mk > index cac127f..41ee86d 100644 > --- a/fs/common.mk > +++ b/fs/common.mk > @@ -106,6 +106,7 @@ rootfs-$(1): $$(BINARIES_DIR)/rootfs.$(1) $$(ROOTFS_$(2)_POST_TARGETS) > > ifeq ($$(BR2_TARGET_ROOTFS_$(2)),y) > TARGETS_ROOTFS += rootfs-$(1) > +PACKAGES += $$(ROOTFS_$(2)_DEPENDENCIES) This will break the rest of your series for filesystems like ubi and initramfs that depend on another filesystem, because filesystems are not really packages so they shouldn't be in PACKAGES. Regards, Arnout > endif > endef > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F