From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] new functions libxl_bitmap_{or,and} Date: Tue, 14 Apr 2015 13:28:48 +0100 Message-ID: <552D0800.2050801@citrix.com> References: <1428911238-6244-1-git-send-email-lindaj@jma3.com> <20150414091942.GN17670@zion.uk.xensource.com> <552D04B5.7050302@jma3.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <552D04B5.7050302@jma3.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Linda , Wei Liu Cc: lars.kurth.xen@gmail.com, ian.jackson@citrix.com, stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Linda, Hi Linda, On 14/04/15 13:14, Linda wrote: > On 4/14/2015 3:19 AM, Wei Liu wrote: >> Thanks, we're getting there. If my comments confuse you please just ask >> for clarification. >> >> There is no need to change the subject line. However, it would be >> useful if you have some kind of version number in you subject line. That >> is >> >> [PATCH vX] libxl: provide libxl_bimap_{and,or} >> >> You can do this by supplying --subject-prefix= to git format-patch >> >> git format-patch -1 --subject-prefix="[PATCH vX]" ... > What version do you want me to use at this point? I've sort of lost > count, since many changes have been style changes. IIRC, this is the v3, so the next will be v4. > I am assuming you usually reserve new versions for substantive changes? The version number should be incremented every time you send a new version of the patch to the mailing list. >> >> where X refers to your version number. >> >> On Mon, Apr 13, 2015 at 01:47:18AM -0600, Linda Jacobson wrote: >>> provide logical and and or of two bitmaps >>> >> And the SoB line should be here. > What does SoB stand for in this context? Signed-off-by. As said on a previous mail, everything after "---" will be dropped when the committer will apply your patch to the tree. So your SoB will disappear too. You have to move it before the "---" >> >>> --- >>> >>> v.1 updated comments and format >>> v.2 rewrote bitmap functions to manipulate bytes not bits >>> >>> Signed-off-by: Linda Jacobson [..] >> >>> +int libxl_bitmap_or(libxl_ctx *ctx, libxl_bitmap *or_map, >>> + libxl_bitmap *map1, libxl_bitmap *map2) >> Actually I think you need to constify map1 and map2. I.e. >> >> const libxl_bitmap *map1, >> const libxl_bitmap *map2) > How come? Out of curiosity. You know that the 2 bitmaps won't be modified within function. Constifying them will allow the compiler to catch any attempt to modify the content of the bitmap. Regards, -- Julien Grall