From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiD2h-0001vF-Gs for qemu-devel@nongnu.org; Tue, 14 Apr 2015 22:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiD2e-0005Bj-AD for qemu-devel@nongnu.org; Tue, 14 Apr 2015 22:27:07 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:52622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiD2d-0005BD-LD for qemu-devel@nongnu.org; Tue, 14 Apr 2015 22:27:04 -0400 Message-ID: <552DCC58.6030003@huawei.com> Date: Wed, 15 Apr 2015 10:26:32 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com> <1428055432-12120-2-git-send-email-zhaoshenglong@huawei.com> In-Reply-To: <1428055432-12120-2-git-send-email-zhaoshenglong@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 01/20] hw/i386: Move ACPI header definitions in an arch-independent location List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, christoffer.dall@linaro.org, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, imammedo@redhat.com, hanjun.guo@linaro.org, mst@redhat.com, lersek@redhat.com, msalter@redhat.com Cc: hangaohuai@huawei.com, peter.huangpeng@huawei.com, shannon.zhao@linaro.org On 2015/4/3 18:03, Shannon Zhao wrote: > From: Shannon Zhao > > The ACPI related header file acpi-defs.h, includes definitions that > apply on other architectures as well. Move it in `include/hw/acpi/` > to sanely include it from other architectures. > > Signed-off-by: Alvise Rigo > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/i386/acpi-build.c | 2 +- > hw/i386/acpi-defs.h | 368 -------------------------------------------- > include/hw/acpi/acpi-defs.h | 368 ++++++++++++++++++++++++++++++++++++++++++++ > tests/bios-tables-test.c | 2 +- > 4 files changed, 370 insertions(+), 370 deletions(-) > delete mode 100644 hw/i386/acpi-defs.h > create mode 100644 include/hw/acpi/acpi-defs.h Hi Igor, Michael， Could you help review the patch 01, 02 of this patchset as they are releated to x86 ACPI? -- Thanks, Shannon