From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 15 Apr 2015 10:45:09 +0200
Subject: [U-Boot] [PATCH v2 10/13] arm: mvebu: Add dynamic SoC detection
 to mbus driver
In-Reply-To: <20150414173105.40f74c27@free-electrons.com>
References: <1429008415-27458-1-git-send-email-sr@denx.de>	<1429008415-27458-11-git-send-email-sr@denx.de>
 <20150414173105.40f74c27@free-electrons.com>
Message-ID: <552E2515.7040208@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Thomas,

On 14.04.2015 17:31, Thomas Petazzoni wrote:
> On Tue, 14 Apr 2015 12:46:52 +0200, Stefan Roese wrote:
>
>> +			if (mvebu_soc_family() == MVEBU_SOC_AXP)
>> +				w->mbus_attr |= ATTR_HW_COHERENCY;
>
> Why is this Armada XP specific? Both Armada XP and Armada 38x support
> HW I/O coherency. But are you actually using HW I/O coherency in U-Boot
> for Armada XP ?

No, not really. This file is pretty much cloned from the Linux version. 
So its a remnant from there. Even though this coherency is not used in 
U-Boot.

> It would probably be simpler to not use HW I/O coherency at all in
> U-Boot, be it for AXP or A38x.

Right. I'll remove this, either in a new patchset version or in a follow 
up patch. Thanks for the hint.

Thanks,
Stefan