From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yig5d-0002Jj-0w for qemu-devel@nongnu.org; Thu, 16 Apr 2015 05:28:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yig5Y-00049e-Qp for qemu-devel@nongnu.org; Thu, 16 Apr 2015 05:28:04 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:45704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yig5Y-00049U-Lg for qemu-devel@nongnu.org; Thu, 16 Apr 2015 05:28:00 -0400 Message-ID: <552F809A.2040308@imgtec.com> Date: Thu, 16 Apr 2015 10:27:54 +0100 From: Leon Alrae MIME-Version: 1.0 References: <1427894283-31953-1-git-send-email-leon.alrae@imgtec.com> <9DE872C8-4AE3-48FC-B4A1-61ADE4DB7F32@livius.net> <551CF623.7040506@imgtec.com> <551D086D.9010604@imgtec.com> <551D1BC2.10408@imgtec.com> <1C30C43D-CD89-4EBF-991A-9CC53019ED7B@livius.net> <6D39441BF12EF246A7ABCE6654B023532101BA54@LEMAIL01.le.imgtec.org> <1741D364-48FC-4682-B660-82A5B48F8DE4@livius.net> <55255556.8020504@imgtec.com> <2A76D025-D3C9-4023-B48B-F6870998C99A@livius.net> <552E514E.1030204@imgtec.com> <428A086F-92EB-4A25-9A96-849317AD4E02@livius.net> <552E5E59.90108@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liviu Ionescu Cc: "peter.maydell@linaro.org" , "christopher.covington@linaro.org" , Matthew Fortune , "qemu-devel@nongnu.org" On 15/04/2015 17:08, Liviu Ionescu wrote: > >> On 15 Apr 2015, at 15:49, Leon Alrae wrote: >> >> ... If there aren't any objections for the proposed solution, then let's >> just cook up the patch. > > the changes related to moving --semihosting-cmdline to the end of the line are in: > > git://git.code.sf.net/p/gnuarmeclipse/qemu gnuarmeclipse-qemu > > the gnuarmeclipse-dev branch, commit 8010d2 > > although I did not group the semihosting related variables in a structure, that code may still be a good starting point (especially since it is already functional in my fork). > > I suggest you compare the gnuarmeclipse-dev branch with master and get the semihosting related patches. > > if you need any help, please don't hesitate to ask. > > alternatively I can create the patch, but the changes must also touch non-arm code, and I have no experience there. Since the new option and your ARM semi-hosting improvements already work for you I believe it would be much easier if you sent the patches first rather than us figuring out the changes from your branch. Then we could go from there reviewing / refining / testing etc. Thanks, Leon