From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 3/9] raisin: add QEMU upstream component
Date: Thu, 16 Apr 2015 10:54:51 +0100
Message-ID: <552F86EB.50803@eu.citrix.com>
References: <alpine.DEB.2.02.1504151602460.7690@kaball.uk.xensource.com>
	<1429110900-8286-3-git-send-email-stefano.stabellini@eu.citrix.com>
	<552EB66F.7090105@citrix.com>
	<alpine.DEB.2.02.1504161049550.7690@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1504161049550.7690@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 04/16/2015 10:51 AM, Stefano Stabellini wrote:
> On Wed, 15 Apr 2015, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 15/04/2015 16:14, Stefano Stabellini wrote:
>>> diff --git a/components/series b/components/series
>>> index 3c3124d..8f614f0 100644
>>> --- a/components/series
>>> +++ b/components/series
>>> @@ -1,3 +1,4 @@
>>>   xen
>>> +qemu
>>>   grub
>>>   libvirt
>>> diff --git a/components/xen b/components/xen
>>> index 2d345a8..dcf2f92 100644
>>> --- a/components/xen
>>> +++ b/components/xen
>>> @@ -23,7 +23,7 @@ function xen_build() {
>>>       cd "$BASEDIR"
>>>       git-checkout $XEN_UPSTREAM_URL $XEN_UPSTREAM_REVISION xen-dir
>>>       cd xen-dir
>>> -    ./configure --prefix=$PREFIX
>>> +    ./configure --prefix=$PREFIX
>>> --with-system-qemu=/usr/bin/qemu-system-i386
>>
>> Currently the QEMU built by Xen is installed in a Xen directory (IIRC
>> /usr/lib/xen/bin). Should not you use a similar path for raisin? Otherwise you
>> would override the QEMU installed via the distrib package
>> manager.
> 
> This was done on purpose because the QEMU component built by Raisin
> should be generally usable, even without Xen.

Do we want raisin to clobber / conflict with a system qemu by befault?

I think if our goal is, "A Xen-focused configuration that Just Works",
putting it in /usr/lib/xen/bin is probably better.

 -George