From: "Jan Beulich" <JBeulich@suse.com>
To: "Rafał Wojdyła" <omeg@invisiblethingslab.com>
Cc: xen-devel@lists.xen.org
Subject: Re: Error in gnttab documentation
Date: Thu, 16 Apr 2015 09:32:06 +0100 [thread overview]
Message-ID: <552F8FA60200007800072958@mail.emea.novell.com> (raw)
In-Reply-To: <552EC04C.50503@invisiblethingslab.com>
>>> On 15.04.15 at 21:47, <omeg@invisiblethingslab.com> wrote:
> There is an erroneous statement in the public header grant_table.h
> regarding GNTTABOP_map_grant_ref:
>
> "On error, <handle> is a negative status code." [1]
>
> This is not the case. Only the gnttab_map_grant_ref.status field is
> set on errors most of the time. [2]
First of all - why didn't you simply send a patch to correct this? And
then - why do you say "most of the time"? Is there any path which
fails to do so, or sets .handle to some error indicator? I can't seem
to be able to spot any...
Jan
> [1]
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/gra
> nt_table.h;h=c8619ed50dda6d3b1bdc73faeb5622f5eccad1ac;hb=refs/heads/mast
> er#l324
>
> [2]
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/common/grant_table
> .c;h=dfb45f8d6661fc60379abd29597bc23e55d674ff;hb=refs/heads/master#l591
>
> - --
> Rafał Wojdyła
> Qubes Tools for Windows developer
> https://www.qubes-os.org/
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-04-16 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 19:47 Error in gnttab documentation Rafał Wojdyła
2015-04-16 8:32 ` Jan Beulich [this message]
2015-04-16 9:04 ` Ian Campbell
2015-04-16 11:22 ` Rafał Wojdyła
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552F8FA60200007800072958@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=omeg@invisiblethingslab.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.