From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v3 3/3] xen: rework paging_log_dirty_op to work with hvm guests Date: Thu, 16 Apr 2015 10:49:21 +0100 Message-ID: <552FA1C10200007800072A9B@mail.emea.novell.com> References: <1428686959-2890-1-git-send-email-roger.pau@citrix.com> <1428686959-2890-4-git-send-email-roger.pau@citrix.com> <552D20D70200007800071E38@mail.emea.novell.com> <20150416091118.GC13443@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YigQE-0003qN-Oj for xen-devel@lists.xenproject.org; Thu, 16 Apr 2015 09:49:23 +0000 In-Reply-To: <20150416091118.GC13443@deinos.phlegethon.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: Andrew Cooper , xen-devel@lists.xenproject.org, Roger Pau Monne List-Id: xen-devel@lists.xenproject.org >>> On 16.04.15 at 11:11, wrote: > At 13:14 +0100 on 14 Apr (1429017287), Jan Beulich wrote: >> > This won't work: The paging lock protects all of >> > d->arch.paging.preempt.log_dirty, of which you hold cached values >> > in local variables. >> >> ... so how about reusing the existing restart code instead? We could >> either move the label further up or tail-recurse into it. Possibly - I didn't look too closely though at how feasible this would be. Jan