From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965013AbbDPL6i (ORCPT ); Thu, 16 Apr 2015 07:58:38 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:48256 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964991AbbDPL6a (ORCPT ); Thu, 16 Apr 2015 07:58:30 -0400 Message-ID: <552FA3DC.90709@ti.com> Date: Thu, 16 Apr 2015 14:58:20 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Peter Chen CC: , , , , , , , , , Subject: Re: [RFC][PATCH v2 02/13] usb: otg-fsm: support multiple instances References: <1429008120-5395-1-git-send-email-rogerq@ti.com> <1429008120-5395-3-git-send-email-rogerq@ti.com> <20150416113559.GB3181@shlinux2> In-Reply-To: <20150416113559.GB3181@shlinux2> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/15 14:36, Peter Chen wrote: > On Tue, Apr 14, 2015 at 01:41:49PM +0300, Roger Quadros wrote: >> Move the state_changed variable into struct otg_fsm >> so that we can support multiple instances. > > OTG device has only one port. See 3.1.1. > If you go to pass OTG Certification, the lab requires that there is only > one port at your board. > We're not breaking OTG compliance by this ;). Moreover this structure is not limited to OTG but for DRD (dual-role) use as well. We can have multiple DRD ports per board. cheers, -roger >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/common/usb-otg-fsm.c | 10 ++++------ >> include/linux/usb/otg-fsm.h | 1 + >> 2 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c >> index 1736bbe..0caa37b 100644 >> --- a/drivers/usb/common/usb-otg-fsm.c >> +++ b/drivers/usb/common/usb-otg-fsm.c >> @@ -61,8 +61,6 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol) >> return 0; >> } >> >> -static int state_changed; >> - >> /* Called when leaving a state. Do state clean up jobs here */ >> static void otg_leave_state(struct otg_fsm *fsm, enum usb_otg_state old_state) >> { >> @@ -123,7 +121,7 @@ static void otg_leave_state(struct otg_fsm *fsm, enum usb_otg_state old_state) >> /* Called when entering a state */ >> static int otg_set_state(struct otg_fsm *fsm, enum usb_otg_state new_state) >> { >> - state_changed = 1; >> + fsm->state_changed = 1; >> if (fsm->otg->state == new_state) >> return 0; >> VDBG("Set state: %s\n", usb_otg_state_string(new_state)); >> @@ -255,7 +253,7 @@ int otg_statemachine(struct otg_fsm *fsm) >> mutex_lock(&fsm->lock); >> >> state = fsm->otg->state; >> - state_changed = 0; >> + fsm->state_changed = 0; >> /* State machine state change judgement */ >> >> switch (state) { >> @@ -368,7 +366,7 @@ int otg_statemachine(struct otg_fsm *fsm) >> } >> mutex_unlock(&fsm->lock); >> >> - VDBG("quit statemachine, changed = %d\n", state_changed); >> - return state_changed; >> + VDBG("quit statemachine, changed = %d\n", fsm->state_changed); >> + return fsm->state_changed; >> } >> EXPORT_SYMBOL_GPL(otg_statemachine); >> diff --git a/include/linux/usb/otg-fsm.h b/include/linux/usb/otg-fsm.h >> index c5b74c5..85a9150 100644 >> --- a/include/linux/usb/otg-fsm.h >> +++ b/include/linux/usb/otg-fsm.h >> @@ -183,6 +183,7 @@ struct otg_fsm { >> /* Current usb protocol used: 0:undefine; 1:host; 2:client */ >> int protocol; >> struct mutex lock; >> + bool state_changed; >> }; >> >> struct otg_fsm_ops { >> -- >> 2.1.0 >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [RFC][PATCH v2 02/13] usb: otg-fsm: support multiple instances Date: Thu, 16 Apr 2015 14:58:20 +0300 Message-ID: <552FA3DC.90709@ti.com> References: <1429008120-5395-1-git-send-email-rogerq@ti.com> <1429008120-5395-3-git-send-email-rogerq@ti.com> <20150416113559.GB3181@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150416113559.GB3181@shlinux2> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Chen Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org, mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On 16/04/15 14:36, Peter Chen wrote: > On Tue, Apr 14, 2015 at 01:41:49PM +0300, Roger Quadros wrote: >> Move the state_changed variable into struct otg_fsm >> so that we can support multiple instances. > > OTG device has only one port. See 3.1.1. > If you go to pass OTG Certification, the lab requires that there is only > one port at your board. > We're not breaking OTG compliance by this ;). Moreover this structure is not limited to OTG but for DRD (dual-role) use as well. We can have multiple DRD ports per board. cheers, -roger >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/common/usb-otg-fsm.c | 10 ++++------ >> include/linux/usb/otg-fsm.h | 1 + >> 2 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c >> index 1736bbe..0caa37b 100644 >> --- a/drivers/usb/common/usb-otg-fsm.c >> +++ b/drivers/usb/common/usb-otg-fsm.c >> @@ -61,8 +61,6 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol) >> return 0; >> } >> >> -static int state_changed; >> - >> /* Called when leaving a state. Do state clean up jobs here */ >> static void otg_leave_state(struct otg_fsm *fsm, enum usb_otg_state old_state) >> { >> @@ -123,7 +121,7 @@ static void otg_leave_state(struct otg_fsm *fsm, enum usb_otg_state old_state) >> /* Called when entering a state */ >> static int otg_set_state(struct otg_fsm *fsm, enum usb_otg_state new_state) >> { >> - state_changed = 1; >> + fsm->state_changed = 1; >> if (fsm->otg->state == new_state) >> return 0; >> VDBG("Set state: %s\n", usb_otg_state_string(new_state)); >> @@ -255,7 +253,7 @@ int otg_statemachine(struct otg_fsm *fsm) >> mutex_lock(&fsm->lock); >> >> state = fsm->otg->state; >> - state_changed = 0; >> + fsm->state_changed = 0; >> /* State machine state change judgement */ >> >> switch (state) { >> @@ -368,7 +366,7 @@ int otg_statemachine(struct otg_fsm *fsm) >> } >> mutex_unlock(&fsm->lock); >> >> - VDBG("quit statemachine, changed = %d\n", state_changed); >> - return state_changed; >> + VDBG("quit statemachine, changed = %d\n", fsm->state_changed); >> + return fsm->state_changed; >> } >> EXPORT_SYMBOL_GPL(otg_statemachine); >> diff --git a/include/linux/usb/otg-fsm.h b/include/linux/usb/otg-fsm.h >> index c5b74c5..85a9150 100644 >> --- a/include/linux/usb/otg-fsm.h >> +++ b/include/linux/usb/otg-fsm.h >> @@ -183,6 +183,7 @@ struct otg_fsm { >> /* Current usb protocol used: 0:undefine; 1:host; 2:client */ >> int protocol; >> struct mutex lock; >> + bool state_changed; >> }; >> >> struct otg_fsm_ops { >> -- >> 2.1.0 >> > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html