From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/1] x86/hvm: prevent hvm_free_ioreq_gmfn() clobber of arbitrary memory Date: Thu, 16 Apr 2015 19:44:57 +0100 Message-ID: <55300329.40807@citrix.com> References: <1428940903-18302-1-git-send-email-dslutz@verizon.com> <552D1A820200007800071DF7@mail.emea.novell.com> <552D1375.8050204@citrix.com> <20150416105312.GE13443@deinos.phlegethon.org> <552FB9FC0200007800072BCD@mail.emea.novell.com> <20150416163700.GK13441@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150416163700.GK13441@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan , xen-devel@lists.xen.org Cc: Keir Fraser , Jan Beulich , Don Slutz List-Id: xen-devel@lists.xenproject.org On 16/04/15 17:37, Tim Deegan wrote: > At 12:32 +0100 on 16 Apr (1429187564), Jan Beulich wrote: >>>>> On 16.04.15 at 12:53, wrote: >>> I would be inclined to use a bigger hammer here. IMO refactoring like >>> this makes it easier to reason about (compile tested only): >> This looks like a pretty nice cleanup; I particularly like the 4 labels >> going away. > OK, here it is as a proper patch. I still haven't tested it -- indeed > I'm not sure how to test multiple ioreq clients. Any suggestions? > > From 67957b954f2b8d58b635a8e5fdc818154ec9e4ff Mon Sep 17 00:00:00 2001 > From: Tim Deegan > Date: Thu, 16 Apr 2015 17:34:24 +0100 > Subject: [PATCH] x86/hvm: refactor code that allocates ioreq gfns. > > It was confusing GCC's uninitialized-variable detection. > > Signed-off-by: Tim Deegan Reviewed-by: Andrew Cooper