Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer

From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer
Date: Fri, 17 Apr 2015 14:46:25 +0200	[thread overview]
Message-ID: <553100A1.2070007@redhat.com> (raw)
In-Reply-To: <w51fv80ywku.fsf@maestria.local.igalia.com>

On 16.04.2015 16:30, Alberto Garcia wrote:
> On Wed 15 Apr 2015 06:09:18 PM CEST, Max Reitz <mreitz@redhat.com> wrote:
>
>>> +    orig_bs_flags = bdrv_get_flags(bs);
>>> +    if (!(orig_bs_flags & BDRV_O_RDWR)) {
>> I feel like we don't want to do this if we're not streaming to an
>> intermediate layer but to the top layer (because that means there is
>> some reason for the BDS to be read-only beyond it just being a backing
>> BDS).
> Looks like we don't actually need to do anything, bdrv_reopen_prepare()
> already takes care of checking the BDRV_O_ALLOW_RDWR flag, which is not
> set if the image was opened in read-only mode.

Oh, that's nice. :-)

Max