From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yk4YR-0001jv-5C for qemu-devel@nongnu.org; Mon, 20 Apr 2015 01:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yk4YN-00049u-42 for qemu-devel@nongnu.org; Mon, 20 Apr 2015 01:47:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yk4YM-00049q-VF for qemu-devel@nongnu.org; Mon, 20 Apr 2015 01:47:31 -0400 Message-ID: <55348E2C.9010403@redhat.com> Date: Mon, 20 Apr 2015 13:27:08 +0800 From: Jason Wang MIME-Version: 1.0 References: <1429246120-29439-1-git-send-email-jasowang@redhat.com> <1429246120-29439-8-git-send-email-jasowang@redhat.com> <20150417133103.1c3bbd80.cornelia.huck@de.ibm.com> In-Reply-To: <20150417133103.1c3bbd80.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 07/16] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Christian Borntraeger , Alexander Graf , Richard Henderson , qemu-devel@nongnu.org, mst@redhat.com On 04/17/2015 07:31 PM, Cornelia Huck wrote: > On Fri, 17 Apr 2015 12:48:31 +0800 > Jason Wang wrote: > >> There's no need to use vector 0 for invalid virtqueue. So this patch > s/There's no need/It's a bad idea/ > >> changes to use VIRTIO_NO_VECTOR instead. > s/use/using/ > >> Cc: Michael S. Tsirkin >> Cc: Cornelia Huck >> CC: Christian Borntraeger >> Cc: Richard Henderson >> Cc: Alexander Graf >> Signed-off-by: Jason Wang >> --- >> hw/s390x/virtio-ccw.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Cornelia Huck > Will change the log as you've suggested. Thanks.