From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yk4FG-0006HK-Oj for qemu-devel@nongnu.org; Mon, 20 Apr 2015 01:27:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yk4FC-0007Ji-2k for qemu-devel@nongnu.org; Mon, 20 Apr 2015 01:27:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yk4FB-0007Je-RD for qemu-devel@nongnu.org; Mon, 20 Apr 2015 01:27:41 -0400 Message-ID: <55348E45.20100@redhat.com> Date: Mon, 20 Apr 2015 13:27:33 +0800 From: Jason Wang MIME-Version: 1.0 References: <1429246120-29439-1-git-send-email-jasowang@redhat.com> <1429246120-29439-10-git-send-email-jasowang@redhat.com> <20150417134643.00d7f398.cornelia.huck@de.ibm.com> In-Reply-To: <20150417134643.00d7f398.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 09/16] virtio-ccw: introduce ccw specific queue limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Alexander Graf , Richard Henderson , qemu-devel@nongnu.org, Christian Borntraeger , mst@redhat.com On 04/17/2015 07:46 PM, Cornelia Huck wrote: > On Fri, 17 Apr 2015 12:48:33 +0800 > Jason Wang wrote: > >> Instead of depending on marco, using a bus specific limit. Also make >> it clear that the number of gsis per I/O adapter is not directly >> depending on the number of virtio queues, but rather the other way >> around. >> >> Cc: Alexander Graf >> Cc: Cornelia Huck >> Cc: Christian Borntraeger >> Cc: Richard Henderson >> Signed-off-by: Jason Wang >> --- >> hw/s390x/s390-virtio-ccw.c | 7 +++++-- >> hw/s390x/virtio-ccw.c | 19 ++++++++++++------- >> include/hw/s390x/s390_flic.h | 4 +++- >> 3 files changed, 20 insertions(+), 10 deletions(-) >> >> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c >> index 590eed5..f197ef8 100644 >> --- a/hw/s390x/virtio-ccw.c >> +++ b/hw/s390x/virtio-ccw.c > (...) > > You seem to have missed the case in virtio_ccw_cb (READ_VQ_CONF)? > Yes. Will correct this in next version. Thanks