From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkA96-0002KE-MW for qemu-devel@nongnu.org; Mon, 20 Apr 2015 07:45:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkA8z-0002Zp-1R for qemu-devel@nongnu.org; Mon, 20 Apr 2015 07:45:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkA8y-0002Zf-Rt for qemu-devel@nongnu.org; Mon, 20 Apr 2015 07:45:40 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id DC17EA10D6 for ; Mon, 20 Apr 2015 11:45:39 +0000 (UTC) Message-ID: <5534E6DF.7020004@redhat.com> Date: Mon, 20 Apr 2015 13:45:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429521560-2743-1-git-send-email-kraxel@redhat.com> <1429521560-2743-5-git-send-email-kraxel@redhat.com> In-Reply-To: <1429521560-2743-5-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: lersek@redhat.com, mst@redhat.com On 20/04/2015 11:19, Gerd Hoffmann wrote: > + memory_region_del_subregion(mch->system_memory, &mch->tseg_blackhole); > + memory_region_set_enabled(&mch->tseg_blackhole, tseg_size); Please use "tseg_size > 0" here. Paolo > + memory_region_set_size(&mch->tseg_blackhole, tseg_size); > + memory_region_add_subregion_overlap(mch->system_memory, > + mch->below_4g_mem_size - tseg_size, > + &mch->tseg_blackhole, 1);