From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkCwG-0003zH-5W for qemu-devel@nongnu.org; Mon, 20 Apr 2015 10:44:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkCwC-0002gE-SE for qemu-devel@nongnu.org; Mon, 20 Apr 2015 10:44:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkCwC-0002gA-MX for qemu-devel@nongnu.org; Mon, 20 Apr 2015 10:44:40 -0400 Message-ID: <5535052C.6080701@redhat.com> Date: Mon, 20 Apr 2015 15:54:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427391520-29497-1-git-send-email-pbonzini@redhat.com> <1427391520-29497-5-git-send-email-pbonzini@redhat.com> <20150420131114.GB21246@stefanha-thinkpad.redhat.com> In-Reply-To: <20150420131114.GB21246@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org On 20/04/2015 15:11, Stefan Hajnoczi wrote: >> - memory_region_set_coalescing(&s->mem_vram); + >> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA); > > This change isn't 100% clear to me. I guess that coalescing > (performance optimization) doesn't make sense when logging is > enabled? No, it's just that coalescing is for MMIO, not RAM. Setting coalescing was a no-op. I'll make this a separate patch. Paolo