From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [RFC][PATCH 08/13] tools: extend xc_assign_device() to support rdm reservation policy Date: Mon, 20 Apr 2015 14:39:40 +0100 Message-ID: <55351DBC0200007800073CA6@mail.emea.novell.com> References: <1428657724-3498-1-git-send-email-tiejun.chen@intel.com> <1428657724-3498-9-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1428657724-3498-9-git-send-email-tiejun.chen@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tiejun Chen Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org >>> On 10.04.15 at 11:21, wrote: > --- a/tools/libxc/xc_domain.c > +++ b/tools/libxc/xc_domain.c > @@ -1654,13 +1654,15 @@ int xc_domain_setdebugging(xc_interface *xch, > int xc_assign_device( > xc_interface *xch, > uint32_t domid, > - uint32_t machine_sbdf) > + uint32_t machine_sbdf, > + uint32_t flag) > { > DECLARE_DOMCTL; > > domctl.cmd = XEN_DOMCTL_assign_device; > domctl.domain = domid; > domctl.u.assign_device.machine_sbdf = machine_sbdf; > + domctl.u.assign_device.sbdf_flag = flag; The previous patch needs to initialize this field, in order to not pass random input to the hypervisor. Using the ..._TRY value here intermediately (until this patch gets applied) would seem the right approach. Jan