From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v20 02/13] x86/VPMU: Add public xenpmu.h
Date: Mon, 20 Apr 2015 12:38:04 -0400
Message-ID: <55352B6C.3040300@oracle.com>
References: <1428594295-2024-1-git-send-email-boris.ostrovsky@oracle.com>
	<1428594295-2024-3-git-send-email-boris.ostrovsky@oracle.com>
	<5534D9E80200007800073962@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5534D9E80200007800073962@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, suravee.suthikulpanit@amd.com, andrew.cooper3@citrix.com, tim@xen.org, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org, Aravind.Gopalakrishnan@amd.com, jun.nakajima@intel.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org


On 04/20/2015 04:50 AM, Jan Beulich wrote:
>>>> On 09.04.15 at 17:44, <boris.ostrovsky@oracle.com> wrote:
>> --- /dev/null
>> +++ b/xen/include/public/pmu.h
>> @@ -0,0 +1,38 @@
>> +#ifndef __XEN_PUBLIC_PMU_H__
>> +#define __XEN_PUBLIC_PMU_H__
>> +
>> +#include "xen.h"
>> +#if defined(__i386__) || defined(__x86_64__)
>> +#include "arch-x86/pmu.h"
>> +#elif defined (__arm__) || defined (__aarch64__)
>> +#include "arch-arm.h"
>> +#else
>> +#error "Unsupported architecture"
>> +#endif
>> +
>> +#define XENPMU_VER_MAJ    0
>> +#define XENPMU_VER_MIN    1
>> +
>> +
>> +/* Shared between hypervisor and PV domain */
>> +struct xen_pmu_data {
> Iirc this sharing is r/o - if so, please state so in the comment. If not,
> please extend the comment to briefly explain why writable sharing
> is safe/secure.

This data structure is writeable by guest (specifically, PMU registers 
and APIC_LVTPC). There is a flag (PMU_CACHED, which is part of this 
structure) that the hypervisor sets to let the guest know that it can 
write those fields without having to trap. When the guest is done, it 
issues XENPMU_flush command and the hypervisor writes out those values 
to HW.

I'll update the comments to make this clear.

-boris