From mboxrd@z Thu Jan 1 00:00:00 1970 From: YOSHIFUJI Hideaki Subject: Re: [PATCH] neighbour.c: Avoid GC directly after state change Date: Tue, 21 Apr 2015 12:58:56 +0900 Message-ID: <5535CB00.4060209@miraclelinux.com> References: <1426107673-45049-1-git-send-email-netdev@emagii.com> <20150312.142621.1128728353472907283.davem@davemloft.net> <5527892D.4020608@ericsson.com> <552F45AA.6010906@miraclelinux.com> <5530BE40.1000504@ericsson.com> <55346580.6060801@miraclelinux.com> <5534F5B8.1030405@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: hideaki.yoshifuji@miraclelinux.com, netdev@vger.kernel.org To: Ulf Samuelsson , netdev@emagii.com Return-path: Received: from exprod7og111.obsmtp.com ([64.18.2.175]:54281 "HELO exprod7og111.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752107AbbDUEGT (ORCPT ); Tue, 21 Apr 2015 00:06:19 -0400 Received: by mail-pa0-f51.google.com with SMTP id oj16so227816776pab.0 for ; Mon, 20 Apr 2015 21:06:19 -0700 (PDT) In-Reply-To: <5534F5B8.1030405@ericsson.com> Sender: netdev-owner@vger.kernel.org List-ID: Ulf Samuelsson wrote: >> How many neighbors do you want to maintain? >> I guess you have to increase the number of gc_thresh1. > The current use cases have up to 2048 entries. > This is expected to grow in the future. > The 3.4 kernel used in the system today is limited to 1024, > but that has been raised to about 10k. > > The gc_thresh1 test is not implemented in 3.4 but can be backported, > but still not convinced it is a good idea. Why? > To complicate things, one requirement is that for some interfaces > you always want to keep things alive, if connected, but > for other interfaces you want things to be removed > to conserve memory. > Actually you would want to do this selection on a subnet level. If you want to introduce per-interface parameter, I am okay with it. > > Internal discussions resulted in a proposal to change the patch, > so that you have a "keepalive" flag which is tested after > it has been decided to exit the REACHABLE state. > > if the "keepalive" flag is set, you always go to DELAY state from REACHABLE. No. -- Hideaki Yoshifuji Technical Division, MIRACLE LINUX CORPORATION