From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626E8C432BE for ; Fri, 23 Jul 2021 12:57:10 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id B71FA60E95 for ; Fri, 23 Jul 2021 12:57:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B71FA60E95 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E586D40040; Fri, 23 Jul 2021 14:57:08 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id C76594003C; Fri, 23 Jul 2021 14:57:07 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6ECAF5C012A; Fri, 23 Jul 2021 08:57:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 23 Jul 2021 08:57:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= nhDytJEMYmNl9f4YxPiMvYw28eCqBNL23tLP0AzUpv4=; b=nQQ5jDTHLB2kQGZe AzTpVtPA61yxtsiqTbqu0L2gGi3FW4gYTxoTaaBlGUN1XrhunnFbt+TbBpV6QcaV dt5D6+I6/0/RjhX8jEPywG8eQnDfNi3SolSCoZX3L0ZTmEysxdeIkqjmbcmd9wI3 1dLqjSuwjKE8O7wfPDB3+x/09pK+p3RzDUNUGFj/KgsiLRl+simlU5i4qUoSwpzj iBO33au7/AJgb3nV8TNqzWpS6Xi569ehEFE5G7VSWsMKZdAXW62UMBLFHkzVA39a KQcL52X1dndwhK8AJb5gYfzXWGqYVwpY5L73sHo6M1Gq68S7DnZUK7/I7wvpIL+K TAQhYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=nhDytJEMYmNl9f4YxPiMvYw28eCqBNL23tLP0AzUp v4=; b=dcJ7/6/ZP5A3aHc1F3GsnBtnEA+djIa5mBMb3XkScdOIWFslzxH46w1bC efn/CzHKR8eS05RB26lRY8dss9yT9u+Jj8ejvhS/9nDNY2InPn4D8IedJY6yQNVe 0MFouPAg57QGkC0/+mFkfbkM0fDWGxw1Rr2ou7uFl49tccyimsA5BQbT/TGzlgCX mhRukesv0k3nCPpiXEr5iLitIn90eKFZH8a9yEdIvy2SNKsWBvufAvv/OpsKNf3V aTIyjBGuWjQnxfWwCLJB2IKxdvsZGv6RR1v1ArSNblWRgGyYOWClJWX9AlqlMvlm OuIq/wY900SQPKAQmXCML008r4LUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeekgdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 08:57:06 -0400 (EDT) From: Thomas Monjalon To: viacheslavo@nvidia.com, Jiawei Wang Cc: matan@nvidia.com, orika@nvidia.com, Shahaf Shuler , dev@dpdk.org, rasland@nvidia.com, stable@dpdk.org Date: Fri, 23 Jul 2021 14:57:27 +0200 Message-ID: <5536161.f2duC4C3qX@thomas> In-Reply-To: <20210723124338.18269-1-jiaweiw@nvidia.com> References: <20210723124338.18269-1-jiaweiw@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2021 14:43, Jiawei Wang: > Due to hardware limitations, the decap action can't follow the Which decap action? Pleas be more specific. > sample action in the same flow, to keep the original action order > of sample and decap actions the flow was internally split by PMD, > and decap action was moved into suffix subflow in the new table. "the" new table? which one? Was there an issue? Above seems to say all is fine. > There is a specific combination of raw decap and raw encap actions > to specify "L3 encapsulation" packet transformation - raw decap action > to remove L2 header and raw encap to add the tunnel header. Is this combination the problem? It was not working before this patch? Please describe what happened. > This specific L3 encapsulation is encoded as a single packet reformat > hardware transaction and is supported by hardware after sample > action (no hardware limitations for packet reformat). > > The patch checks whether the decap action is the part of "L3 encapsulation" I think you mean "is part of". > and does not move the decap action into suffix subflow for the case. > > Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions with mirror") > Cc: stable@dpdk.org > > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko