From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753056AbbDUJlU (ORCPT ); Tue, 21 Apr 2015 05:41:20 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:22040 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbbDUJlT convert rfc822-to-8bit (ORCPT ); Tue, 21 Apr 2015 05:41:19 -0400 Message-ID: <55361B3B.3060505@arm.com> Date: Tue, 21 Apr 2015 10:41:15 +0100 From: "Suzuki K. Poulose" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Tyler Baker , Shuah Khan CC: Kevin Hilman , John Stultz , Darren Hart , David Herrmann , Michael Ellerman , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled References: <1429571661-26337-1-git-send-email-tyler.baker@linaro.org> In-Reply-To: <1429571661-26337-1-git-send-email-tyler.baker@linaro.org> X-OriginalArrivalTime: 21 Apr 2015 09:41:15.0553 (UTC) FILETIME=[4F9D1110:01D07C17] X-MC-Unique: WF3xmAAvReWmhKTEgw8xNQ-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/04/15 00:14, Tyler Baker wrote: > The breakpoints test should only should be executed on x86 targets, so lets > emit a skip and omit the installation when ARCH != x86. > > Acked-by: Michael Ellerman > Signed-off-by: Tyler Baker > --- > tools/testing/selftests/breakpoints/Makefile | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile > index 1822356..430b76d 100644 > --- a/tools/testing/selftests/breakpoints/Makefile > +++ b/tools/testing/selftests/breakpoints/Makefile > @@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64) > ARCH := x86 > endif > > - > all: > ifeq ($(ARCH),x86) > gcc breakpoint_test.c -o breakpoint_test > @@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test > > include ../lib.mk > > +install: > +ifneq ($(ARCH),x86) > +echo "Not an x86 target, can't install breakpoints selftests" It would make more sense to send this to stderr than stdout, people may look for errors there. Cheers Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suzuki.Poulose@arm.com (Suzuki K. Poulose) Date: Tue, 21 Apr 2015 10:41:15 +0100 Subject: [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled In-Reply-To: <1429571661-26337-1-git-send-email-tyler.baker@linaro.org> References: <1429571661-26337-1-git-send-email-tyler.baker@linaro.org> Message-ID: <55361B3B.3060505@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 21/04/15 00:14, Tyler Baker wrote: > The breakpoints test should only should be executed on x86 targets, so lets > emit a skip and omit the installation when ARCH != x86. > > Acked-by: Michael Ellerman > Signed-off-by: Tyler Baker > --- > tools/testing/selftests/breakpoints/Makefile | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile > index 1822356..430b76d 100644 > --- a/tools/testing/selftests/breakpoints/Makefile > +++ b/tools/testing/selftests/breakpoints/Makefile > @@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64) > ARCH := x86 > endif > > - > all: > ifeq ($(ARCH),x86) > gcc breakpoint_test.c -o breakpoint_test > @@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test > > include ../lib.mk > > +install: > +ifneq ($(ARCH),x86) > +echo "Not an x86 target, can't install breakpoints selftests" It would make more sense to send this to stderr than stdout, people may look for errors there. Cheers Suzuki