From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkZmr-00041q-B4 for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:08:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkZmm-0008VJ-3P for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:08:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkZml-0008V3-SS for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:08:28 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3LF8Rxw012222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 21 Apr 2015 11:08:27 -0400 Message-ID: <553667E6.6010704@redhat.com> Date: Tue, 21 Apr 2015 17:08:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429521560-2743-1-git-send-email-kraxel@redhat.com> <1429521560-2743-5-git-send-email-kraxel@redhat.com> <55365C33.2090101@redhat.com> <1429628650.21164.24.camel@nilsson.home.kraxel.org> In-Reply-To: <1429628650.21164.24.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Laszlo Ersek Cc: qemu-devel@nongnu.org, mst@redhat.com On 21/04/2015 17:04, Gerd Hoffmann wrote: > Hmm. I think if we merge all the smm / smram / tseg patches in one go > this should work. Without patches reading the ESMRAMC register returns > zero. With the patches the three cache-disable bits are hardcoded to > '1'. This should work for detecting tseg support. > > You also have to test for smm support. The current protocol for this is > that seabios checks whenever smm is already initialized (see > *_apmc_smm_setup() in seabios/src/fw/smm.c) and if so it skips smm > initialization. Right now qemu sets the bit on reset when running on > kvm, so seabios doesn't try to use smm. On tcg the bit is clear after > reset and seabios actually uses smm mode. BTW, I plan to add "-machine smm=yes/no/auto". Gerd, are you going to implement SMI_EN locking as well? Paolo