From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH RFC 5/5] drm/i915: Implement
 intel_crtc_toggle using atomic state
Date: Wed, 22 Apr 2015 16:18:45 +0200
Message-ID: <5537ADC5.1080302@linux.intel.com>
References: <1429701862-22970-1-git-send-email-maarten.lankhorst@linux.intel.com>
 <1429701862-22970-6-git-send-email-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6655089ECD
 for <intel-gfx@lists.freedesktop.org>; Wed, 22 Apr 2015 07:18:48 -0700 (PDT)
In-Reply-To: <1429701862-22970-6-git-send-email-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T3AgMjItMDQtMTUgb20gMTM6MjQgc2NocmVlZiBtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRl
bC5jb206Cj4gRnJvbTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4
LmludGVsLmNvbT4KPgo+IEFzc3VtZSB0aGUgZnVuY3Rpb24gaXMgbG9ja2VkIHdpdGggZHJtX21v
ZGVzZXRfbG9ja19hbGwgZm9yIG5vdy4KPgo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hv
cnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDEzMSArKysrKysrKysrLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgOTMgZGVs
ZXRpb25zKC0pCj4gPHNuaXA+Cj4gIHN0YXRpYyB2b2lkIGlyb25sYWtlX2NydGNfZW5hYmxlKHN0
cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNy
dGMtPmRldjsKPiBAQCAtNTcyOCwxMCArNTY1MiwxMyBAQCBzdGF0aWMgdm9pZCBpOXh4X2NydGNf
ZGlzYWJsZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIHZvaWQgaW50ZWxfY3J0Y19jb250cm9s
KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywgYm9vbCBlbmFibGUpCj4gIHsKPiAgCXN0cnVjdCBkcm1f
ZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICsJc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29u
ZmlnID0gJmRldi0+bW9kZV9jb25maWc7Cj4gKwlzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9j
dHggKmN0eCA9IGNvbmZpZy0+YWNxdWlyZV9jdHg7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50
ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gLQllbnVtIGludGVsX2Rpc3BsYXlfcG93
ZXJfZG9tYWluIGRvbWFpbjsKPiAtCXVuc2lnbmVkIGxvbmcgZG9tYWluczsKPiArCXN0cnVjdCBp
bnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZzsKPiArCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUg
KnBsYW5lX3N0YXRlOwo+ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ICsJaW50
IHJldDsKPiAgCj4gIAlpZiAoZW5hYmxlID09IGludGVsX2NydGMtPmFjdGl2ZSkKPiAgCQlyZXR1
cm47Cj4gQEAgLTU3NDAsMjMgKzU2NjcsNDEgQEAgdm9pZCBpbnRlbF9jcnRjX2NvbnRyb2woc3Ry
dWN0IGRybV9jcnRjICpjcnRjLCBib29sIGVuYWJsZSkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJY3J0
Yy0+c3RhdGUtPmFjdGl2ZSA9IGVuYWJsZTsKXk9vcHMsIHRoaXMgbGluZSBzaG91bGQgYmUgcmVt
b3ZlZCBub3cgb3IgdGhpcyBwYXRjaCB3aWxsIGdsaXRjaCBiYWRseS4KCkFuZCBhIGxvdCBvZiBw
bGFjZXMgdGhhdCB1c2Ugc3RhdGUtPmVuYWJsZSBzaG91bGQgdXNlIHN0YXRlLT5hY3RpdmUgaW5z
dGVhZC4KClN0aWxsIGxlYXZpbmcgdGhpcyBoZXJlIGFzIGl0J3MgYSBSRkMuIDotKQo+IC0JaWYg
KGVuYWJsZSkgewo+IC0JCWRvbWFpbnMgPSBnZXRfY3J0Y19wb3dlcl9kb21haW5zKGNydGMpOwo+
IC0JCWZvcl9lYWNoX3Bvd2VyX2RvbWFpbihkb21haW4sIGRvbWFpbnMpCj4gLQkJCWludGVsX2Rp
c3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LCBkb21haW4pOwo+IC0JCWludGVsX2NydGMtPmVuYWJs
ZWRfcG93ZXJfZG9tYWlucyA9IGRvbWFpbnM7Cj4gIAo+IC0JCWRldl9wcml2LT5kaXNwbGF5LmNy
dGNfZW5hYmxlKGNydGMpOwo+IC0JCWludGVsX2NydGNfZW5hYmxlX3BsYW5lcyhjcnRjKTsKPiAt
CX0gZWxzZSB7Cj4gLQkJaW50ZWxfY3J0Y19kaXNhYmxlX3BsYW5lcyhjcnRjKTsKPiAtCQlkZXZf
cHJpdi0+ZGlzcGxheS5jcnRjX2Rpc2FibGUoY3J0Yyk7Cj4gKwkvKiB0aGlzIGZ1bmN0aW9uIHNo
b3VsZCBiZSBjYWxsZWQgd2l0aCBkcm1fbW9kZXNldF9sb2NrX2FsbCBmb3Igbm93ICovCj4gKwlp
ZiAoV0FSTl9PTighY3R4KSkKPiArCQlyZXR1cm47Cj4gKwlsb2NrZGVwX2Fzc2VydF9oZWxkKCZj
dHgtPnd3X2N0eCk7Cj4gIAo+IC0JCWRvbWFpbnMgPSBpbnRlbF9jcnRjLT5lbmFibGVkX3Bvd2Vy
X2RvbWFpbnM7Cj4gLQkJZm9yX2VhY2hfcG93ZXJfZG9tYWluKGRvbWFpbiwgZG9tYWlucykKPiAt
CQkJaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoZGV2X3ByaXYsIGRvbWFpbik7Cj4gLQkJaW50ZWxf
Y3J0Yy0+ZW5hYmxlZF9wb3dlcl9kb21haW5zID0gMDsKPiArCXN0YXRlID0gZHJtX2F0b21pY19z
dGF0ZV9hbGxvYyhkZXYpOwo+ICsJaWYgKFdBUk5fT04oIXN0YXRlKSkKPiArCQlyZXR1cm47Cj4g
Kwo+ICsJc3RhdGUtPmFjcXVpcmVfY3R4ID0gY3R4Owo+ICsJc3RhdGUtPmFsbG93X21vZGVzZXQg
PSB0cnVlOwo+ICsKPiArCXBpcGVfY29uZmlnID0gaW50ZWxfYXRvbWljX2dldF9jcnRjX3N0YXRl
KHN0YXRlLCBpbnRlbF9jcnRjKTsKPiArCWlmIChJU19FUlIocGlwZV9jb25maWcpKSB7Cj4gKwkJ
cmV0ID0gUFRSX0VSUihwaXBlX2NvbmZpZyk7Cj4gKwkJZ290byBlcnI7Cj4gKwl9Cj4gKwlwaXBl
X2NvbmZpZy0+YmFzZS5hY3RpdmUgPSBlbmFibGU7Cj4gKwo+ICsJcGxhbmVfc3RhdGUgPSBkcm1f
YXRvbWljX2dldF9wbGFuZV9zdGF0ZShzdGF0ZSwgY3J0Yy0+cHJpbWFyeSk7Cj4gKwlpZiAoSVNf
RVJSKHBsYW5lX3N0YXRlKSkgewo+ICsJCXJldCA9IFBUUl9FUlIocGxhbmVfc3RhdGUpOwo+ICsJ
CWdvdG8gZXJyOwo+ICAJfQo+ICsKPiArCXJldCA9IGludGVsX3NldF9tb2RlKGNydGMsIHN0YXRl
KTsKPiArCWlmICghcmV0KQo+ICsJCXJldHVybjsKPiArCj4gKwlEUk1fRVJST1IoIkZhaWxlZCB0
byB0b2dnbGUgY3J0YyFcbiIpOwo+ICsKPiArZXJyOgo+ICsJRFJNX0VSUk9SKCJVcGRhdGluZyBj
cnRjIGFjdGl2ZSBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsKPiArCWRybV9hdG9taWNfc3RhdGVf
ZnJlZShzdGF0ZSk7Cj4gIH0KPiAgCj4gIC8qKgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngK