All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Zhao <shannon.zhao@linaro.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com,
	peter.huangpeng@huawei.com, qemu-devel@nongnu.org,
	zhaoshenglong@huawei.com, pbonzini@redhat.com,
	christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net
Date: Thu, 23 Apr 2015 08:31:26 +0800	[thread overview]
Message-ID: <55383D5E.5050708@linaro.org> (raw)
In-Reply-To: <20150422162410.10c36694.cornelia.huck@de.ibm.com>

On 2015/4/22 22:24, Cornelia Huck wrote:
> On Tue, 21 Apr 2015 18:51:10 +0800
> shannon.zhao@linaro.org wrote:
> 
> I'd drop the leading "hw/net/" from the subject.
> 

Ok, thanks.

>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net.
>> The transports just sync the host features from backend.
>> Meanwhile move virtio_net_set_config_size to virtio-net.
> 
> Could you elaborate on why this makes sense?
> 

Ok, will add.

>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>>  hw/net/virtio-net.c            | 5 +++++
>>  hw/s390x/s390-virtio-bus.c     | 2 --
>>  hw/s390x/virtio-ccw.c          | 2 --
>>  hw/virtio/virtio-pci.c         | 2 --
>>  include/hw/virtio/virtio-net.h | 1 +
>>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> FWIW, this survives basic sanity checks on virtio-ccw - also in
> combination with my realization sequence reordering patches I sent
> yesterday.
> 
> Haven't gotten around to s390-virtio or virtio-scsi yet.
> 

-- 
Shannon

  reply	other threads:[~2015-04-23  0:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 10:51 [Qemu-devel] [PATCH v3 0/2] virtio: Move host features to backends shannon.zhao
2015-04-21 10:51 ` [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net shannon.zhao
2015-04-22 14:24   ` Cornelia Huck
2015-04-23  0:31     ` Shannon Zhao [this message]
2015-04-21 10:51 ` [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi shannon.zhao
2015-04-28  0:32   ` Shannon Zhao
2015-04-28  5:55     ` Michael S. Tsirkin
2015-04-28  6:30       ` Shannon Zhao
2015-04-28  7:15         ` Michael S. Tsirkin
2015-04-28  7:28           ` Shannon Zhao
2015-04-28  8:18             ` Michael S. Tsirkin
2015-04-28  9:29               ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55383D5E.5050708@linaro.org \
    --to=shannon.zhao@linaro.org \
    --cc=christoffer.dall@linaro.org \
    --cc=cornelia.huck@de.ibm.com \
    --cc=hangaohuai@huawei.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.