Re: [BUG] having 'plink' anywhere in the GIT_SSH environment variables sets putty = true

From: "Torsten Bögershausen" <tboegi@web.de>
To: Patrick Sharp <jakanapes@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: Git Mailing List <git@vger.kernel.org>,
	sandals@crustytoothpaste.net, peff@peff.net,
	Duy Nguyen <pclouds@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	msysGit <msysgit@googlegroups.com>
Subject: Re: [BUG] having 'plink' anywhere in the GIT_SSH environment variables sets putty = true
Date: Thu, 23 Apr 2015 07:08:01 +0200	[thread overview]
Message-ID: <55387E31.5010100@web.de> (raw)
In-Reply-To: <F1AB6016-DA88-446C-84E9-1BD42436843D@gmail.com>

On 04/22/2015 09:12 PM, Patrick Sharp wrote:
> Johannes,
>
> You’re correct, looking back over it, I was pretty vague.
>
> In truth, we are not using Windows OR putty at all.  Running git on an Ubuntu system, but we are setting the GIT_SSH environment variable to point to a shell script to use.
>
> Upon attempting to run git ls-remote, the system was spitting out getaddrinfo errors for ‘atch’ .
>
> Setting GIT_TRACE=2 showed that -batch was being added to the git command.
>
> This was seen on several different servers with git versions 1.8.5.2, 1.9.1 and 2.3.5
>
> After a bit we realized that it was the string ‘uplink’ in the GIT_SSH variable that was linked to the extra -batch flag.
>
> Finally, after searching the git source, we narrowed it down to the ‘plink’ portion of the string.
>
> https://github.com/git/git/blob/7c597ef345aed345576de616c51f27e6f4b342b3/connect.c#L747-L7
Brian, I got your patch,
but can't see it in the list yet
  1/2 looks good, thanks.
(And add msygit)

My feeling is that  patch 2/2 may break things for an unknown
amount of users which e.g. use "myplink".

Patrick,
did you ever tell us, what you put into $GIT_SSH ?

Can your use case be covered by using $GIT_SSH_COMMAND ?