From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlQDm-0002kt-1T for qemu-devel@nongnu.org; Thu, 23 Apr 2015 19:07:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlQDh-0007PB-TE for qemu-devel@nongnu.org; Thu, 23 Apr 2015 19:07:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlQDh-0007Oz-Md for qemu-devel@nongnu.org; Thu, 23 Apr 2015 19:07:45 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 3DC398EAFB for ; Thu, 23 Apr 2015 23:07:45 +0000 (UTC) Message-ID: <55397B40.3070602@redhat.com> Date: Thu, 23 Apr 2015 17:07:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1429793161-25677-1-git-send-email-kchamart@redhat.com> In-Reply-To: <1429793161-25677-1-git-send-email-kchamart@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1OMhw7TOLokQkjq9TRKesfiB7hhfdcXdN" Subject: Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1OMhw7TOLokQkjq9TRKesfiB7hhfdcXdN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/23/2015 06:46 AM, Kashyap Chamarthy wrote: > Although the canonical source of reference for QMP commands is > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > state the list of supported transactionable operations, namely: >=20 > drive-backup > blockdev-backup > blockdev-snapshot-internal-sync > abort > block-dirty-bitmap-add > block-dirty-bitmap-clear >=20 > NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-add' commands > will be available once the in-review "transactionless incremental > backup" patch series[1] is merged upstream. >=20 > [1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.ht= ml >=20 > Signed-off-by: Kashyap Chamarthy > --- > qmp-commands.hx | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >=20 > =20 > -Atomically operate on one or more block devices. The only supported o= perations > -for now are drive-backup, internal and external snapshotting. A list = of > -dictionaries is accepted, that contains the actions to be performed. > -If there is any failure performing any of the operations, all operatio= ns > -for the group are abandoned. > +Atomically operate on one or more block devices. Operations that are > +currently supported: drive-backup, blockdev-backup, > +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, > +block-dirty-bitmap-add, block-dirty-bitmap-clear (refer s/refer/refer to the/ > +qemu/qapi-schema.json file for minimum required QEMU versions for thes= e > +commands). A list of dictionaries is accepted, that contains the actio= ns > +to be performed. If there is any failure performing any of the > +operations, all operations for the group are abandoned. > =20 With that change, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1OMhw7TOLokQkjq9TRKesfiB7hhfdcXdN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVOXtAAAoJEKeha0olJ0NqtTkIAJCOH8tJJOS8mOJ/kwXNZMLQ ALBtTJJCzuYTRVp9aXxyT31S7Iq3Lk3WKc8r+SiO8ElatEQGNGaBnqTneMUenATN wc6iMl2gWvkKFzXZx6pu1Kn0g6MQFfmRzFnVVMosmaUEWrcczaIZzCnINNhgxYFp yhcufd2Ih9dHv88zavnP6MG65swIB+4hohPxEZAnc5pIAD6AhWeS8x0E5u0oBeRO PRtE2Eb5Lc2y9e9M+nXAcMAowkJpQxrYd5U0TLQe/b1TCS3Y+6B6bvynmTttATsH j8SbQ1a+8lTIAVEGQTJksCgNsCiuVbgnvd/xqNrPPyW71SgyWHV16/6qsfdH9NY= =Qixj -----END PGP SIGNATURE----- --1OMhw7TOLokQkjq9TRKesfiB7hhfdcXdN--