From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: [PATCH] libxl: initialize vfb defbools
	in	libxlMakeVfb
Date: Fri, 24 Apr 2015 14:05:48 -0600
Message-ID: <553AA21C.60005__29077.0754022107$1429908244$gmane$org@suse.com>
References: <1429291171-23640-1-git-send-email-olaf@aepfle.de>	<553161CA.2090906@suse.com>
	<20150418064723.GA2488@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150418064723.GA2488@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: libvir-list@redhat.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Olaf Hering wrote:
> On Fri, Apr 17, Jim Fehlig wrote:
>
>   
>> On 04/17/2015 11:19 AM, Olaf Hering wrote:
>>     
>>> +            libxl_defbool_set(&x_vfb->vnc.enable, 0);
>>>       
>> Not shown here, but just before the switch is
>>
>>      libxl_device_vfb_init(x_vfb);
>>
>> which IIUC (looking at the impl in $xensrc/tools/libxl/_libxl_types.c)
>> should initialize the vfb struct with default values.
>>     
>
> Yes, but the default values lead to the assert.
>   

Ok, best to be a bit defensive.  I've pushed the patch now.

Regards,
Jim