From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: [PATCH] libxl: initialize vfb defbools in
	libxlMakeVfb
Date: Fri, 24 Apr 2015 14:19:44 -0600
Message-ID: <553AA560.1030008__34123.4637810432$1429910941$gmane$org@suse.com>
References: <1429291171-23640-1-git-send-email-olaf@aepfle.de>
	<20150417175928.GA2516@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150417175928.GA2516@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: libvir-list@redhat.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Olaf Hering wrote:
> On Fri, Apr 17, Olaf Hering wrote:
>
>   
>> If the domU configu has sdl enabled libvirtd crashes:
>> libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed.
>>
>> Initialize the relevant defbool variables in libxl_device_vfb.
>>     
>
> Fix one crash, find another:
>
> Does libvirt have a representation for this one?
>
>   libxl_defbool_val(vfb.sdl.opengl));
>
> If not, it should be initialized to false in libxlMakeVfb.
>   

Hrm, missed adding this before pushing your original patch.  I'm going
to push a trivial follow-up.

Regards,
Jim