From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 3.mo583.mail-out.ovh.net (3.mo583.mail-out.ovh.net [46.105.40.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB4BB79DA for ; Sat, 7 Jan 2023 21:52:08 +0000 (UTC) Received: from director2.ghost.mail-out.ovh.net (unknown [10.109.138.83]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 66D5320ACE for ; Sat, 7 Jan 2023 20:36:55 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-lxtls (unknown [10.110.115.90]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id BD8F71FE98; Sat, 7 Jan 2023 20:36:50 +0000 (UTC) Received: from sk2.org ([37.59.142.105]) by ghost-submission-6684bf9d7b-lxtls with ESMTPSA id eSsCKuLXuWPI3wUAubRvvA (envelope-from ); Sat, 07 Jan 2023 20:36:50 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-105G0067839b063-0764-4415-809e-52a6ec1d72ef, DAE31E0ADBCC733EDB52157E78EF0D9B49FF90DC) smtp.auth=steve@sk2.org X-OVh-ClientIp:37.167.110.121 Date: Sat, 07 Jan 2023 21:36:47 +0100 From: Stephen Kitt To: sam@ravnborg.org, Sam Ravnborg via B4 Submission Endpoint , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han CC: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Sam Ravnborg , Ludovic Desroches Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_01/15=5D_video=3A_fbdev=3A_atm?= =?US-ASCII?Q?el=5Flcdfb=3A_Rework_backlight_handling?= User-Agent: K-9 Mail for Android In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-1-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-1-1bd9bafb351f@ravnborg.org> Message-ID: <553AE999-CAF1-4E59-9F3F-68591ED192DE@sk2.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 15557403441115072134 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkedvgddufeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevufgfjghfkfggtgfgsehtqhhmtddtreejnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeekvddvteekgedtkefgueefheetheefffdtfeeuveettdejjeeutdetkefggeegleenucffohhmrghinheplhhkmhhlrdhorhhgnecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqshhtrghgihhngheslhhishhtshdrlhhinhhugidruggvvhdpoffvtefjohhsthepmhhoheekfedpmhhouggvpehsmhhtphhouhht On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: >From: Sam Ravnborg > >The atmel_lcdfb had code to save/restore power state=2E >This is not needed so drop it=2E > >Introduce backlight_is_brightness() to make logic simpler=2E > >Signed-off-by: Sam Ravnborg >Cc: Nicolas Ferre >Cc: Alexandre Belloni >Cc: Ludovic Desroches >Cc: linux-fbdev@vger=2Ekernel=2Eorg >Cc: linux-arm-kernel@lists=2Einfradead=2Eorg >--- > drivers/video/fbdev/atmel_lcdfb=2Ec | 24 +++--------------------- > 1 file changed, 3 insertions(+), 21 deletions(-) > >diff --git a/drivers/video/fbdev/atmel_lcdfb=2Ec b/drivers/video/fbdev/at= mel_lcdfb=2Ec >index 1fc8de4ecbeb=2E=2Ed297b3892637 100644 >--- a/drivers/video/fbdev/atmel_lcdfb=2Ec >+++ b/drivers/video/fbdev/atmel_lcdfb=2Ec >@@ -49,7 +49,6 @@ struct atmel_lcdfb_info { > struct clk *lcdc_clk; >=20 > struct backlight_device *backlight; >- u8 bl_power; > u8 saved_lcdcon; >=20 > u32 pseudo_palette[16]; >@@ -109,32 +108,18 @@ static u32 contrast_ctr =3D ATMEL_LCDC_PS_DIV8 > static int atmel_bl_update_status(struct backlight_device *bl) > { > struct atmel_lcdfb_info *sinfo =3D bl_get_data(bl); >- int power =3D sinfo->bl_power; >- int brightness =3D bl->props=2Ebrightness; >+ int brightness; >=20 >- /* REVISIT there may be a meaningful difference between >- * fb_blank and power =2E=2E=2E there seem to be some cases >- * this doesn't handle correctly=2E >- */ >- if (bl->props=2Efb_blank !=3D sinfo->bl_power) >- power =3D bl->props=2Efb_blank; >- else if (bl->props=2Epower !=3D sinfo->bl_power) >- power =3D bl->props=2Epower; >- >- if (brightness < 0 && power =3D=3D FB_BLANK_UNBLANK) >- brightness =3D lcdc_readl(sinfo, ATMEL_LCDC_CONTRAST_VAL); >- else if (power !=3D FB_BLANK_UNBLANK) >- brightness =3D 0; >+ brightness =3D backlight_get_brightness(bl); >=20 > lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_VAL, brightness); >+ > if (contrast_ctr & ATMEL_LCDC_POL_POSITIVE) > lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, > brightness ? contrast_ctr : 0); > else > lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, contrast_ctr); >=20 >- bl->props=2Efb_blank =3D bl->props=2Epower =3D sinfo->bl_power =3D powe= r; >- > return 0; > } >=20 >@@ -155,8 +140,6 @@ static void init_backlight(struct atmel_lcdfb_info *s= info) > struct backlight_properties props; > struct backlight_device *bl; >=20 >- sinfo->bl_power =3D FB_BLANK_UNBLANK; >- > if (sinfo->backlight) > return; >=20 >@@ -173,7 +156,6 @@ static void init_backlight(struct atmel_lcdfb_info *s= info) > sinfo->backlight =3D bl; >=20 > bl->props=2Epower =3D FB_BLANK_UNBLANK; >- bl->props=2Efb_blank =3D FB_BLANK_UNBLANK; > bl->props=2Ebrightness =3D atmel_bl_get_brightness(bl); > } >=20 > Hi Sam, I=E2=80=99d submitted quite a few more of these previously (and you=E2=80= =99d reviewed them), see e=2Eg=2E the thread starting at https://lkml=2Eorg= /lkml/2022/6/7/4365, and yesterday, https://lkml=2Eorg/lkml/2023/1/6/520, h= ttps://lkml=2Eorg/lkml/2023/1/6/656, https://lkml=2Eorg/lkml/2023/1/6/970, = https://lkml=2Eorg/lkml/2023/1/6/643, and https://lkml=2Eorg/lkml/2023/1/6/= 680=2E There are a few more, I can find them if it=E2=80=99s any use=2E Regards, Stephen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34131C46467 for ; Sat, 7 Jan 2023 20:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:References: In-Reply-To:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mTGr1QAZ8U1uKB8PKPpTtYB19QsHEZ/QQyyL+gW0PRk=; b=bMk5fyVmn0Oc78 YecoflXzm+ESq2Vb/edj9EZC84FbyizsUs95/PpDOJ1+YB62yKcPMSB38ovBlGUTDpVDw1geh09wP thWp2LVmDwTH92W4dYNNRmz7zfGFXMTB+Uc9OnBeDQs/Nov9NZcr7OCpxCNGzplKnXqy01j5mAMi2 KqoCyvxV31BSLnfQTG+UT6/p0QeMg47Fn7bRdz+PbztbRuLHZKJndIj3CwEeaokVotG2IbhhFknd5 vOOknWwIr4h2CNFdxU1geO97yrcimYDDSw3eY/3g31IggC33ADefmvKDAVmzRSrY44DOO8KqsSR79 Irz4yeDa0GnMkZKKqBTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEFwD-008JR2-Ag; Sat, 07 Jan 2023 20:37:09 +0000 Received: from 17.mo561.mail-out.ovh.net ([87.98.178.58]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEFw6-008JPl-FE for linux-arm-kernel@lists.infradead.org; Sat, 07 Jan 2023 20:37:05 +0000 Received: from director2.ghost.mail-out.ovh.net (unknown [10.109.146.175]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 783DF250C3 for ; Sat, 7 Jan 2023 20:36:55 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-lxtls (unknown [10.110.115.90]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id BD8F71FE98; Sat, 7 Jan 2023 20:36:50 +0000 (UTC) Received: from sk2.org ([37.59.142.105]) by ghost-submission-6684bf9d7b-lxtls with ESMTPSA id eSsCKuLXuWPI3wUAubRvvA (envelope-from ); Sat, 07 Jan 2023 20:36:50 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-105G0067839b063-0764-4415-809e-52a6ec1d72ef, DAE31E0ADBCC733EDB52157E78EF0D9B49FF90DC) smtp.auth=steve@sk2.org X-OVh-ClientIp: 37.167.110.121 Date: Sat, 07 Jan 2023 21:36:47 +0100 From: Stephen Kitt To: sam@ravnborg.org, Sam Ravnborg via B4 Submission Endpoint , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han CC: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Sam Ravnborg , Ludovic Desroches Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_01/15=5D_video=3A_fbdev=3A_atm?= =?US-ASCII?Q?el=5Flcdfb=3A_Rework_backlight_handling?= User-Agent: K-9 Mail for Android In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-1-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-1-1bd9bafb351f@ravnborg.org> Message-ID: <553AE999-CAF1-4E59-9F3F-68591ED192DE@sk2.org> MIME-Version: 1.0 X-Ovh-Tracer-Id: 15557403441115072134 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkedvgddufeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevufgfjghfkfggtgfgsehtqhhmtddtreejnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeekvddvteekgedtkefgueefheetheefffdtfeeuveettdejjeeutdetkefggeegleenucffohhmrghinheplhhkmhhlrdhorhhgnecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdfovfetjfhoshhtpehmohehiedupdhmohguvgepshhmthhpohhuth X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230107_123702_842388_821C87D1 X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gNyBKYW51YXJ5IDIwMjMgMTk6MjY6MTUgQ0VULCBTYW0gUmF2bmJvcmcgdmlhIEI0IFN1Ym1p c3Npb24gRW5kcG9pbnQgPGRldm51bGwrc2FtLnJhdm5ib3JnLm9yZ0BrZXJuZWwub3JnPiB3cm90 ZToKPkZyb206IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPgo+VGhlIGF0bWVsX2xj ZGZiIGhhZCBjb2RlIHRvIHNhdmUvcmVzdG9yZSBwb3dlciBzdGF0ZS4KPlRoaXMgaXMgbm90IG5l ZWRlZCBzbyBkcm9wIGl0Lgo+Cj5JbnRyb2R1Y2UgYmFja2xpZ2h0X2lzX2JyaWdodG5lc3MoKSB0 byBtYWtlIGxvZ2ljIHNpbXBsZXIuCj4KPlNpZ25lZC1vZmYtYnk6IFNhbSBSYXZuYm9yZyA8c2Ft QHJhdm5ib3JnLm9yZz4KPkNjOiBOaWNvbGFzIEZlcnJlIDxuaWNvbGFzLmZlcnJlQG1pY3JvY2hp cC5jb20+Cj5DYzogQWxleGFuZHJlIEJlbGxvbmkgPGFsZXhhbmRyZS5iZWxsb25pQGJvb3RsaW4u Y29tPgo+Q2M6IEx1ZG92aWMgRGVzcm9jaGVzIDxsdWRvdmljLmRlc3JvY2hlc0BtaWNyb2NoaXAu Y29tPgo+Q2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+Q2M6IGxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+LS0tCj4gZHJpdmVycy92aWRlby9mYmRldi9hdG1lbF9s Y2RmYi5jIHwgMjQgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gMSBmaWxlIGNoYW5nZWQsIDMg aW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCj4KPmRpZmYgLS1naXQgYS9kcml2ZXJzL3Zp ZGVvL2ZiZGV2L2F0bWVsX2xjZGZiLmMgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2F0bWVsX2xjZGZi LmMKPmluZGV4IDFmYzhkZTRlY2JlYi4uZDI5N2IzODkyNjM3IDEwMDY0NAo+LS0tIGEvZHJpdmVy cy92aWRlby9mYmRldi9hdG1lbF9sY2RmYi5jCj4rKysgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2F0 bWVsX2xjZGZiLmMKPkBAIC00OSw3ICs0OSw2IEBAIHN0cnVjdCBhdG1lbF9sY2RmYl9pbmZvIHsK PiAJc3RydWN0IGNsawkJKmxjZGNfY2xrOwo+IAo+IAlzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZQkq YmFja2xpZ2h0Owo+LQl1OAkJCWJsX3Bvd2VyOwo+IAl1OAkJCXNhdmVkX2xjZGNvbjsKPiAKPiAJ dTMyCQkJcHNldWRvX3BhbGV0dGVbMTZdOwo+QEAgLTEwOSwzMiArMTA4LDE4IEBAIHN0YXRpYyB1 MzIgY29udHJhc3RfY3RyID0gQVRNRUxfTENEQ19QU19ESVY4Cj4gc3RhdGljIGludCBhdG1lbF9i bF91cGRhdGVfc3RhdHVzKHN0cnVjdCBiYWNrbGlnaHRfZGV2aWNlICpibCkKPiB7Cj4gCXN0cnVj dCBhdG1lbF9sY2RmYl9pbmZvICpzaW5mbyA9IGJsX2dldF9kYXRhKGJsKTsKPi0JaW50CQkJcG93 ZXIgPSBzaW5mby0+YmxfcG93ZXI7Cj4tCWludAkJCWJyaWdodG5lc3MgPSBibC0+cHJvcHMuYnJp Z2h0bmVzczsKPisJaW50IGJyaWdodG5lc3M7Cj4gCj4tCS8qIFJFVklTSVQgdGhlcmUgbWF5IGJl IGEgbWVhbmluZ2Z1bCBkaWZmZXJlbmNlIGJldHdlZW4KPi0JICogZmJfYmxhbmsgYW5kIHBvd2Vy IC4uLiB0aGVyZSBzZWVtIHRvIGJlIHNvbWUgY2FzZXMKPi0JICogdGhpcyBkb2Vzbid0IGhhbmRs ZSBjb3JyZWN0bHkuCj4tCSAqLwo+LQlpZiAoYmwtPnByb3BzLmZiX2JsYW5rICE9IHNpbmZvLT5i bF9wb3dlcikKPi0JCXBvd2VyID0gYmwtPnByb3BzLmZiX2JsYW5rOwo+LQllbHNlIGlmIChibC0+ cHJvcHMucG93ZXIgIT0gc2luZm8tPmJsX3Bvd2VyKQo+LQkJcG93ZXIgPSBibC0+cHJvcHMucG93 ZXI7Cj4tCj4tCWlmIChicmlnaHRuZXNzIDwgMCAmJiBwb3dlciA9PSBGQl9CTEFOS19VTkJMQU5L KQo+LQkJYnJpZ2h0bmVzcyA9IGxjZGNfcmVhZGwoc2luZm8sIEFUTUVMX0xDRENfQ09OVFJBU1Rf VkFMKTsKPi0JZWxzZSBpZiAocG93ZXIgIT0gRkJfQkxBTktfVU5CTEFOSykKPi0JCWJyaWdodG5l c3MgPSAwOwo+KwlicmlnaHRuZXNzID0gYmFja2xpZ2h0X2dldF9icmlnaHRuZXNzKGJsKTsKPiAK PiAJbGNkY193cml0ZWwoc2luZm8sIEFUTUVMX0xDRENfQ09OVFJBU1RfVkFMLCBicmlnaHRuZXNz KTsKPisKPiAJaWYgKGNvbnRyYXN0X2N0ciAmIEFUTUVMX0xDRENfUE9MX1BPU0lUSVZFKQo+IAkJ bGNkY193cml0ZWwoc2luZm8sIEFUTUVMX0xDRENfQ09OVFJBU1RfQ1RSLAo+IAkJCWJyaWdodG5l c3MgPyBjb250cmFzdF9jdHIgOiAwKTsKPiAJZWxzZQo+IAkJbGNkY193cml0ZWwoc2luZm8sIEFU TUVMX0xDRENfQ09OVFJBU1RfQ1RSLCBjb250cmFzdF9jdHIpOwo+IAo+LQlibC0+cHJvcHMuZmJf YmxhbmsgPSBibC0+cHJvcHMucG93ZXIgPSBzaW5mby0+YmxfcG93ZXIgPSBwb3dlcjsKPi0KPiAJ cmV0dXJuIDA7Cj4gfQo+IAo+QEAgLTE1NSw4ICsxNDAsNiBAQCBzdGF0aWMgdm9pZCBpbml0X2Jh Y2tsaWdodChzdHJ1Y3QgYXRtZWxfbGNkZmJfaW5mbyAqc2luZm8pCj4gCXN0cnVjdCBiYWNrbGln aHRfcHJvcGVydGllcyBwcm9wczsKPiAJc3RydWN0IGJhY2tsaWdodF9kZXZpY2UJKmJsOwo+IAo+ LQlzaW5mby0+YmxfcG93ZXIgPSBGQl9CTEFOS19VTkJMQU5LOwo+LQo+IAlpZiAoc2luZm8tPmJh Y2tsaWdodCkKPiAJCXJldHVybjsKPiAKPkBAIC0xNzMsNyArMTU2LDYgQEAgc3RhdGljIHZvaWQg aW5pdF9iYWNrbGlnaHQoc3RydWN0IGF0bWVsX2xjZGZiX2luZm8gKnNpbmZvKQo+IAlzaW5mby0+ YmFja2xpZ2h0ID0gYmw7Cj4gCj4gCWJsLT5wcm9wcy5wb3dlciA9IEZCX0JMQU5LX1VOQkxBTks7 Cj4tCWJsLT5wcm9wcy5mYl9ibGFuayA9IEZCX0JMQU5LX1VOQkxBTks7Cj4gCWJsLT5wcm9wcy5i cmlnaHRuZXNzID0gYXRtZWxfYmxfZ2V0X2JyaWdodG5lc3MoYmwpOwo+IH0KPiAKPgoKSGkgU2Ft LAoKSeKAmWQgc3VibWl0dGVkIHF1aXRlIGEgZmV3IG1vcmUgb2YgdGhlc2UgcHJldmlvdXNseSAo YW5kIHlvdeKAmWQgcmV2aWV3ZWQgdGhlbSksIHNlZSBlLmcuIHRoZSB0aHJlYWQgc3RhcnRpbmcg YXQgaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMjIvNi83LzQzNjUsIGFuZCB5ZXN0ZXJkYXksIGh0 dHBzOi8vbGttbC5vcmcvbGttbC8yMDIzLzEvNi81MjAsIGh0dHBzOi8vbGttbC5vcmcvbGttbC8y MDIzLzEvNi82NTYsIGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDIzLzEvNi85NzAsIGh0dHBzOi8v bGttbC5vcmcvbGttbC8yMDIzLzEvNi82NDMsIGFuZCBodHRwczovL2xrbWwub3JnL2xrbWwvMjAy My8xLzYvNjgwLiBUaGVyZSBhcmUgYSBmZXcgbW9yZSwgSSBjYW4gZmluZCB0aGVtIGlmIGl04oCZ cyBhbnkgdXNlLgoKUmVnYXJkcywKClN0ZXBoZW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A095C46467 for ; Sat, 7 Jan 2023 21:53:20 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NqDV64CJCz3cBK for ; Sun, 8 Jan 2023 08:53:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sk2.org (client-ip=178.33.251.80; helo=2.mo576.mail-out.ovh.net; envelope-from=steve@sk2.org; receiver=) X-Greylist: delayed 4540 seconds by postgrey-1.36 at boromir; Sun, 08 Jan 2023 08:52:44 AEDT Received: from 2.mo576.mail-out.ovh.net (2.mo576.mail-out.ovh.net [178.33.251.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NqDTS0Dw1z304m for ; Sun, 8 Jan 2023 08:52:41 +1100 (AEDT) Received: from director2.ghost.mail-out.ovh.net (unknown [10.109.143.24]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id AFB8523D43 for ; Sat, 7 Jan 2023 20:36:55 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-lxtls (unknown [10.110.115.90]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id BD8F71FE98; Sat, 7 Jan 2023 20:36:50 +0000 (UTC) Received: from sk2.org ([37.59.142.105]) by ghost-submission-6684bf9d7b-lxtls with ESMTPSA id eSsCKuLXuWPI3wUAubRvvA (envelope-from ); Sat, 07 Jan 2023 20:36:50 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-105G0067839b063-0764-4415-809e-52a6ec1d72ef, DAE31E0ADBCC733EDB52157E78EF0D9B49FF90DC) smtp.auth=steve@sk2.org X-OVh-ClientIp: 37.167.110.121 Date: Sat, 07 Jan 2023 21:36:47 +0100 From: Stephen Kitt To: sam@ravnborg.org, Sam Ravnborg via B4 Submission Endpoint , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_01/15=5D_video=3A_fbdev=3A_atm?= =?US-ASCII?Q?el=5Flcdfb=3A_Rework_backlight_handling?= User-Agent: K-9 Mail for Android In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-1-1bd9bafb351f@ravnborg.org> References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-1-1bd9bafb351f@ravnborg.org> Message-ID: <553AE999-CAF1-4E59-9F3F-68591ED192DE@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 15557403441115072134 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkedvgddufeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevufgfjghfkfggtgfgsehtqhhmtddtreejnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeekvddvteekgedtkefgueefheetheefffdtfeeuveettdejjeeutdetkefggeegleenucffohhmrghinheplhhkmhhlrdhorhhgnecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoshhtvghvvgesshhkvddrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugihpphgtqdguvghvsehlihhsthhsrdhoiihlrggsshdrohhrghdpoffvtefjohhsthepmhhoheejiedpmhhouggvpehsmhhtphhouhht X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Sam Ravnborg , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ludovic Desroches , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: >From: Sam Ravnborg > >The atmel_lcdfb had code to save/restore power state=2E >This is not needed so drop it=2E > >Introduce backlight_is_brightness() to make logic simpler=2E > >Signed-off-by: Sam Ravnborg >Cc: Nicolas Ferre >Cc: Alexandre Belloni >Cc: Ludovic Desroches >Cc: linux-fbdev@vger=2Ekernel=2Eorg >Cc: linux-arm-kernel@lists=2Einfradead=2Eorg >--- > drivers/video/fbdev/atmel_lcdfb=2Ec | 24 +++--------------------- > 1 file changed, 3 insertions(+), 21 deletions(-) > >diff --git a/drivers/video/fbdev/atmel_lcdfb=2Ec b/drivers/video/fbdev/at= mel_lcdfb=2Ec >index 1fc8de4ecbeb=2E=2Ed297b3892637 100644 >--- a/drivers/video/fbdev/atmel_lcdfb=2Ec >+++ b/drivers/video/fbdev/atmel_lcdfb=2Ec >@@ -49,7 +49,6 @@ struct atmel_lcdfb_info { > struct clk *lcdc_clk; >=20 > struct backlight_device *backlight; >- u8 bl_power; > u8 saved_lcdcon; >=20 > u32 pseudo_palette[16]; >@@ -109,32 +108,18 @@ static u32 contrast_ctr =3D ATMEL_LCDC_PS_DIV8 > static int atmel_bl_update_status(struct backlight_device *bl) > { > struct atmel_lcdfb_info *sinfo =3D bl_get_data(bl); >- int power =3D sinfo->bl_power; >- int brightness =3D bl->props=2Ebrightness; >+ int brightness; >=20 >- /* REVISIT there may be a meaningful difference between >- * fb_blank and power =2E=2E=2E there seem to be some cases >- * this doesn't handle correctly=2E >- */ >- if (bl->props=2Efb_blank !=3D sinfo->bl_power) >- power =3D bl->props=2Efb_blank; >- else if (bl->props=2Epower !=3D sinfo->bl_power) >- power =3D bl->props=2Epower; >- >- if (brightness < 0 && power =3D=3D FB_BLANK_UNBLANK) >- brightness =3D lcdc_readl(sinfo, ATMEL_LCDC_CONTRAST_VAL); >- else if (power !=3D FB_BLANK_UNBLANK) >- brightness =3D 0; >+ brightness =3D backlight_get_brightness(bl); >=20 > lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_VAL, brightness); >+ > if (contrast_ctr & ATMEL_LCDC_POL_POSITIVE) > lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, > brightness ? contrast_ctr : 0); > else > lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, contrast_ctr); >=20 >- bl->props=2Efb_blank =3D bl->props=2Epower =3D sinfo->bl_power =3D powe= r; >- > return 0; > } >=20 >@@ -155,8 +140,6 @@ static void init_backlight(struct atmel_lcdfb_info *s= info) > struct backlight_properties props; > struct backlight_device *bl; >=20 >- sinfo->bl_power =3D FB_BLANK_UNBLANK; >- > if (sinfo->backlight) > return; >=20 >@@ -173,7 +156,6 @@ static void init_backlight(struct atmel_lcdfb_info *s= info) > sinfo->backlight =3D bl; >=20 > bl->props=2Epower =3D FB_BLANK_UNBLANK; >- bl->props=2Efb_blank =3D FB_BLANK_UNBLANK; > bl->props=2Ebrightness =3D atmel_bl_get_brightness(bl); > } >=20 > Hi Sam, I=E2=80=99d submitted quite a few more of these previously (and you=E2=80= =99d reviewed them), see e=2Eg=2E the thread starting at https://lkml=2Eorg= /lkml/2022/6/7/4365, and yesterday, https://lkml=2Eorg/lkml/2023/1/6/520, h= ttps://lkml=2Eorg/lkml/2023/1/6/656, https://lkml=2Eorg/lkml/2023/1/6/970, = https://lkml=2Eorg/lkml/2023/1/6/643, and https://lkml=2Eorg/lkml/2023/1/6/= 680=2E There are a few more, I can find them if it=E2=80=99s any use=2E Regards, Stephen