Re: gstreamer1.0-plugins-bad: Update DEPENDS

[Jacob Stiffler <j-stiffler@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 4786 bytes --]

Karthik, Denys,

I have been looking into the build failures for am335x-evm so that we 
may test integrating gstreamer 1.2.

I see that the patch 0001-Added-GstDRMBufferPool-support.patch adds the 
drm support irregardless of whether libdrm was detected. Shouldn't this 
take the approach or EGL in the same file? If HAVE_KMS, then DRM_DIR=drm...

Here's the relevent portion of the patch:

diff --git a/gst-libs/gst/Makefile.am b/gst-libs/gst/Makefile.am
index 1d6cc35..b915d07 100644
--- a/gst-libs/gst/Makefile.am
+++ b/gst-libs/gst/Makefile.am
@@ -2,7 +2,7 @@ if HAVE_EGL
  EGL_DIR = egl
  endif

-SUBDIRS = interfaces basecamerabinsrc codecparsers \
+SUBDIRS = interfaces basecamerabinsrc codecparsers drm \
          insertbin uridownloader mpegts $(EGL_DIR)

  noinst_HEADERS = gst-i18n-plugin.h gettext.h glib-compat-private.h

Let me know if testing the "HAVE_KMS" is the correct approach. I see 
that for including the gstreamer kms plugin, "USE_KMS" is used to 
determine whether to build. From 0003-Added-KMSsink-support.patch:

diff --git a/sys/Makefile.am b/sys/Makefile.am
index b1abda6..b87a1ca 100644
--- a/sys/Makefile.am
+++ b/sys/Makefile.am
@@ -106,6 +106,12 @@ else
  PVR_DIR=
  endif

+if USE_KMS
+KMS_DIR=kms
+else
+KMS_DIR=
+endif
+
  if USE_SHM
  SHM_DIR=shm
  else
@@ -166,9 +172,9 @@ else
  MFC_DIR=
  endif

-SUBDIRS = $(ACM_DIR) $(ANDROID_MEDIA_DIR) $(APPLE_MEDIA_DIR) $(AVC_DIR) 
$(BLUEZ_DIR) $(D3DVIDEOSINK_DIR) $(DECKLINK_DIR) $(DIRECTDRAW_DIR) 
$(DIRECTSOUND_DIR) $(DIRECTSHOW_DIR) $(DVB_DIR) $(FBDEV_DIR) 
$(LINSYS_DIR) $(OPENSLES_DIR) $(OSX_VIDEO_DIR) $(PVR_DIR) $(QT_DIR) 
$(SHM_DIR) $(UVCH264_DIR) $(VCD_DIR) $(VDPAU_DIR) $(WININET_DIR) 
$(WINSCREENCAP_DIR) $(WASAPI_DIR) $(MFC_DIR)
+SUBDIRS = $(ACM_DIR) $(ANDROID_MEDIA_DIR) $(APPLE_MEDIA_DIR) $(AVC_DIR) 
$(BLUEZ_DIR) $(D3DVIDEOSINK_DIR) $(DECKLINK_DIR) $(DIRECTDRAW_DIR) 
$(DIRECTSOUND_DIR) $(DIRECTSHOW_DIR) $(DVB_DIR) $(FBDEV_DIR) 
$(LINSYS_DIR) $(OPENSLES_DIR) $(OSX_VIDEO_DIR) $(PVR_DIR) $(QT_DIR) 
$(KMS_DIR) $(SHM_DIR) $(UVCH264_DIR) $(VCD_DIR) $(VDPAU_DIR) 
$(WININET_DIR) $(WINSCREENCAP_DIR) $(WASAPI_DIR) $(MFC_DIR)

  DIST_SUBDIRS = acmenc acmmp3dec androidmedia applemedia 
applemedia-nonpublic avc bluez d3dvideosink decklink directdraw 
directsound dvb linsys fbdev dshowdecwrapper dshowsrcwrapper 
dshowvideosink \
-               opensles osxvideo pvr2d qtwrapper shm uvch264 vcd vdpau 
wasapi wininet winks winscreencap mfc
+               opensles osxvideo pvr2d qtwrapper kms shm uvch264 vcd 
vdpau wasapi wininet winks winscreencap mfc

  include $(top_srcdir)/common/parallel-subdirs.mak


Thank you,
Jake

On 3/26/2015 11:21 AM, Dmytriyenko, Denys wrote:
>
> Unfortunately, that will make the resulting packages machine specific, 
> which I want to avoid due to build issues we've had with gst 0.10...
>
> -- 
> Denys
>
> On Mar 26, 2015 05:59, "R, Karthik" <karthik.ramanan@ti.com> wrote:
>
>     * Make the feature additions specific to dra7xx due
>        to the dependencies
>
>     Signed-off-by: Karthik Ramanan <a0393906@ti.com>
>     ---
>      .../gstreamer1.0-plugins-bad_1.2.3.bbappend        |    6 ++++--
>      1 file changed, 4 insertions(+), 2 deletions(-)
>
>     diff --git
>     a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.2.3.bbappend
>     b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.2.3.bbappend
>     index b1cacac..72e67f5 100644
>     ---
>     a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.2.3.bbappend
>     +++
>     b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.2.3.bbappend
>     @@ -2,11 +2,13 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
>      PACKAGECONFIG = "faad wayland"
>
>     -SRC_URI_append = " \
>     +DEPENDS_${PN}_append_dra7xx = " libdce libdrm"
>     +
>     +SRC_URI_append_dra7xx = " \
>              file://0001-Added-GstDRMBufferPool-support.patch \
>     file://0002-Modified-waylandsink-to-accept-NV12-format.patch \
>              file://0003-Added-KMSsink-support.patch \
>     file://0004-waylandsink-Removed-dependency-on-dri2.patch \
>     file://0005-vc1parse-and-jpegparse-Fixes-plugin-ranks.patch"
>
>     -PR_append = "-arago0"
>     +PR_append = "-arago1"
>     -- 
>     1.7.9.5
>
>     _______________________________________________
>     meta-arago mailing list
>     meta-arago@arago-project.org
>     http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>
>
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


[-- Attachment #2: Type: text/html, Size: 7858 bytes --]