From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v5 p2 15/19] tools/(lib)xl: Add partial
 device tree support for ARM
Date: Tue, 28 Apr 2015 14:30:35 +0100
Message-ID: <553F8B7B.9010609@citrix.com>
References: <1428592185-18581-1-git-send-email-julien.grall@citrix.com>
	<1428592185-18581-16-git-send-email-julien.grall@citrix.com>
	<21798.42257.11914.504504@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@citrix.com>) id 1Yn5bg-0006RN-2E
	for xen-devel@lists.xenproject.org; Tue, 28 Apr 2015 13:31:24 +0000
In-Reply-To: <21798.42257.11914.504504@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Julien Grall <julien.grall@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, ian.campbell@citrix.com, Julien Grall <julien.grall@linaro.org>, tim@xen.org, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 09/04/15 17:13, Ian Jackson wrote:
> Julien Grall writes ("[PATCH v5 p2 15/19] tools/(lib)xl: Add partial device tree support for ARM"):
>> Let the user to pass additional nodes to the guest device tree. For
>> this purpose, everything in the node /passthrough from the partial
>> device tree will be copied into the guest device tree.
> 
> Thanks for explaining to me in person what I was missing about the
> semantics of DTs.  As I said, you may wish to explain some of this in
> the commit message or some of the in-tree documents, perhaps with
> references.  I will leave that up to you.

I will add a link to [1] in the in-tree documentation (patch #19).

[1] http://www.devicetree.org/Device_Tree_Usage#Basic_Data_Format

> In any case,
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Although:
> 
>> +    # Given the complexity of verifying the validity of a device tree,
>> +    # libxl doesn't do any security check on it. It's the responsability
> 
> Spelling mistake - should be "responsibility".

I will fix it.

Thanks,

-- 
Julien Grall