All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Vecera <ivecera@redhat.com>
To: Sathya Perla <Sathya.Perla@Emulex.Com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Subramanian Seetharaman <subbu.seetharaman@Emulex.Com>,
	Ajit Kumar Khaparde <Ajit.Khaparde@Emulex.Com>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v2] be2net: log link status
Date: Tue, 28 Apr 2015 16:32:37 +0200	[thread overview]
Message-ID: <553F9A05.3020704@redhat.com> (raw)
In-Reply-To: <447118c7-cb5e-4e64-88cc-8205cadfaf5e@CMEXHTCAS2.ad.emulex.com>

On 04/23/2015 08:31 AM, Sathya Perla wrote:
>> -----Original Message-----
>> From: Ivan Vecera [mailto:ivecera@redhat.com]
>>
>> The driver unlike other drivers does not log link state changes.
>>
>> v2: added current link speed to log message
>>
> Ivan, I disagree with the v2 change. I think your original intention
> was just to log a message when the link goes up or down
> asynchronously (i.e., without any user intervention.)
> After alerting the user, if the user wants to know other link
> properties like speed, duplex etc then the ethtool cmd needs
> to be used; there is no need to log a message with those details.
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Dave, could we apply the v1 WRT Sathya's comment?

Thanks,
Ivan

  parent reply	other threads:[~2015-04-28 14:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 13:43 [PATCH net-next v2] be2net: log link status Ivan Vecera
2015-04-22 14:07 ` Joe Perches
2015-04-22 14:17   ` Ivan Vecera
2015-04-22 22:44   ` David Miller
2015-04-23  6:35   ` Sathya Perla
2015-04-23  6:31 ` Sathya Perla
2015-04-23  6:52   ` Ivan Vecera
2015-04-28 14:32   ` Ivan Vecera [this message]
2015-04-28 16:44     ` David Miller
2015-04-28 19:32       ` Ivan Vecera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553F9A05.3020704@redhat.com \
    --to=ivecera@redhat.com \
    --cc=Ajit.Khaparde@Emulex.Com \
    --cc=Sathya.Perla@Emulex.Com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=subbu.seetharaman@Emulex.Com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.