From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v5 02/10] DT: Add documentation for the mfd Maxim max77693 Date: Wed, 29 Apr 2015 14:59:48 +0200 Message-ID: <5540D5C4.7060305@samsung.com> References: <1429080520-10687-1-git-send-email-j.anaszewski@samsung.com> <1429080520-10687-3-git-send-email-j.anaszewski@samsung.com> <20150429123412.GL9169@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:33429 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422850AbbD2M7w (ORCPT ); Wed, 29 Apr 2015 08:59:52 -0400 In-reply-to: <20150429123412.GL9169@x1> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Lee Jones Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, kyungmin.park@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, Andrzej Hajda , Chanwoo Choi , devicetree@vger.kernel.org On 04/29/2015 02:34 PM, Lee Jones wrote: > LED Ack please Bryan. You've already applied v6 with Bryan's ack today :) >> This patch adds device tree binding documentation for >> the flash cell of the Maxim max77693 multifunctional device. >> >> Signed-off-by: Jacek Anaszewski >> Signed-off-by: Andrzej Hajda >> Acked-by: Kyungmin Park >> Cc: Lee Jones >> Cc: Chanwoo Choi >> Cc: Bryan Wu >> Cc: Richard Purdie >> Cc: devicetree@vger.kernel.org >> --- >> Documentation/devicetree/bindings/mfd/max77693.txt | 67 ++++++++++++++++++++ >> 1 file changed, 67 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt >> index 38e6440..d342584 100644 >> --- a/Documentation/devicetree/bindings/mfd/max77693.txt >> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt >> @@ -76,7 +76,60 @@ Optional properties: >> Valid values: 4300000, 4700000, 4800000, 4900000 >> Default: 4300000 >> >> +- led : the LED submodule device node >> + >> +There are two LED outputs available - FLED1 and FLED2. Each of them can >> +control a separate LED or they can be connected together to double >> +the maximum current for a single connected LED. One LED is represented >> +by one child node. >> + >> +Required properties: >> +- compatible : Must be "maxim,max77693-led". >> + >> +Optional properties: >> +- maxim,boost-mode : >> + In boost mode the device can produce up to 1.2A of total current >> + on both outputs. The maximum current on each output is reduced >> + to 625mA then. If not enabled explicitly, boost setting defaults to >> + LEDS_BOOST_FIXED in case both current sources are used. >> + Possible values: >> + LEDS_BOOST_OFF (0) - no boost, >> + LEDS_BOOST_ADAPTIVE (1) - adaptive mode, >> + LEDS_BOOST_FIXED (2) - fixed mode. >> +- maxim,boost-mvout : Output voltage of the boost module in millivolts. >> + Valid values: 3300 - 5500, step by 25 (rounded down) >> + Default: 3300 >> +- maxim,mvsys-min : Low input voltage level in millivolts. Flash is not fired >> + if chip estimates that system voltage could drop below this level due >> + to flash power consumption. >> + Valid values: 2400 - 3400, step by 33 (rounded down) >> + Default: 2400 >> + >> +Required properties for the LED child node: >> +- led-sources : see Documentation/devicetree/bindings/leds/common.txt; >> + device current output identifiers: 0 - FLED1, 1 - FLED2 >> +- led-max-microamp : see Documentation/devicetree/bindings/leds/common.txt >> + Valid values for a LED connected to one FLED output: >> + 15625 - 250000, step by 15625 (rounded down) >> + Valid values for a LED connected to both FLED outputs: >> + 15625 - 500000, step by 15625 (rounded down) >> +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt >> + Valid values for a single LED connected to one FLED output: >> + (boost mode must be turned off): >> + 15625 - 1000000, step by 15625 (rounded down) >> + Valid values for a single LED connected to both FLED outputs: >> + 15625 - 1250000, step by 15625 (rounded down) >> + Valid values for two LEDs case: >> + 15625 - 625000, step by 15625 (rounded down) >> +- flash-max-timeout-us : see Documentation/devicetree/bindings/leds/common.txt >> + Valid values: 62500 - 1000000, step by 62500 (rounded down) >> + >> +Optional properties for the LED child node: >> +- label : see Documentation/devicetree/bindings/leds/common.txt >> + >> Example: >> +#include >> + >> max77693@66 { >> compatible = "maxim,max77693"; >> reg = <0x66>; >> @@ -117,5 +170,19 @@ Example: >> maxim,thermal-regulation-celsius = <75>; >> maxim,battery-overcurrent-microamp = <3000000>; >> maxim,charge-input-threshold-microvolt = <4300000>; >> + >> + led { >> + compatible = "maxim,max77693-led"; >> + maxim,boost-mode = ; >> + maxim,boost-mvout = <5000>; >> + maxim,mvsys-min = <2400>; >> + >> + camera_flash: flash-led { >> + label = "max77693-flash"; >> + led-sources = <0>, <1>; >> + led-max-microamp = <500000>; >> + flash-max-microamp = <1250000>; >> + flash-max-timeout-us = <1000000>; >> + }; >> }; >> }; > -- Best Regards, Jacek Anaszewski