All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak
Date: Wed, 29 Apr 2015 20:17:54 +0300	[thread overview]
Message-ID: <55411242.3090301@msgid.tls.msk.ru> (raw)
In-Reply-To: <1425524720-11376-1-git-send-email-arei.gonglei@huawei.com>

05.03.2015 06:05, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> When not assign a -dtb argument, the variable dtb_filename
> storage returned from qemu_find_file(), which should be freed
> after use. Alternatively we define a local variable filename,
> with 'char *' type, free after use.

Actually now when I look at it all again I think this is the
solution I was thinking about when saying about a "better fix".
I dunno why I haven't seen this before.

I just applied this patch to -trivial. Thank you very much for
your patience!

/mjt

      parent reply	other threads:[~2015-04-29 17:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05  3:05 [Qemu-devel] [PATCH v2] microblaze: fix memory leak arei.gonglei
2015-03-17  7:15 ` Gonglei
2015-03-28  2:37   ` Gonglei
2015-03-28  7:31     ` Edgar E. Iglesias
2015-03-28  7:46       ` Gonglei
2015-03-29 17:09         ` Michael Tokarev
2015-04-28  9:27           ` Gonglei
2015-03-28  2:55 ` Max Filippov
2015-04-29 17:10 ` Peter Crosthwaite
2015-04-29 17:17 ` Michael Tokarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55411242.3090301@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=arei.gonglei@huawei.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.