All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "David Zafra Gómez" <dezeta@klo.es>,
	"Benjamin Tissoires" <benjamin.tissoires@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Duson Lin <dusonlin@emc.com.tw>, Jiri Kosina <jkosina@suse.cz>
Subject: Re: PROBLEM: Touchpad works just like a mouse
Date: Thu, 30 Apr 2015 10:38:09 +0200	[thread overview]
Message-ID: <5541E9F1.5090902@redhat.com> (raw)
In-Reply-To: <5541BEEC.70905@klo.es>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi,

On 30-04-15 07:34, David Zafra Gómez wrote:
> Hi everyone
>
> El 29/04/15 a las 09:35, Hans de Goede escribió:
>> Hi,
>>
>> On 28-04-15 23:26, David Zafra Gómez wrote:
>>> [    0.257439] pnp 00:06: Plug and Play ACPI device, IDs ETD0108
>>> SYN0a00 SYN0002 PNP0f03 PNP0f13 PNP0f12 (active)
>>
>> Ok, so the "ETD0108" here means that you have an elantech ps/2 touchpad.
> Great! You got it.
>>
>> This also stands out in the log:
>>
>> > [    0.958323] i8042: [49] MUX error, status is 75, data is fe
>>
>> So the first thing to try is to boot with i8042.nomux=1 on the kernel
>> commandline.
> I have done it. The touchpad issue hasn't been solved. Do you want me to send dmesg output?

I've taken another look at the traces you've posted before and I think that
I've found the problem. Can you build a kernel with the attached patch
and let us know if that fixes things ?

Regards,

Hans

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-elantech-Fix-detection-of-touchpads-where-the-revisi.patch --]
[-- Type: text/x-patch; name="0001-elantech-Fix-detection-of-touchpads-where-the-revisi.patch", Size: 1338 bytes --]

>From 0b0bf8fd125b0925166470cf8cf9f7b2f310efd4 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Thu, 30 Apr 2015 10:29:38 +0200
Subject: [PATCH] elantech: Fix detection of touchpads where the revision
 matches a known rate
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Make the check to skip the rate check more lax, so that it applies
to all hw_version 4 models.

This fixes the touchpad not being detected properly on Asus PU551LA
laptops.

Reported-and-tested-by: David Zafra Gómez <dezeta@klo.es>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/input/mouse/elantech.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 991dc6b..e30286f 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1379,7 +1379,8 @@ static bool elantech_is_signature_valid(const unsigned char *param)
 	 * Some models have a revision higher then 20. Meaning param[2] may
 	 * be 10 or 20, skip the rates check for these.
 	 */
-	if (param[0] == 0x46 && (param[1] & 0xef) == 0x0f && param[2] < 40)
+	if ((param[0] & 0x0f) >= 0x06 && (param[1] & 0xaf) == 0x0f &&
+	    param[2] < 40)
 		return true;
 
 	for (i = 0; i < ARRAY_SIZE(rates); i++)
-- 
2.3.6


  reply	other threads:[~2015-04-30  8:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <552C4E6C.4070102@klo.es>
2015-04-16  7:54 ` PROBLEM: Touchpad works just like a mouse David Zafra Gómez
2015-04-16 14:44   ` Benjamin Tissoires
2015-04-16 18:38     ` David Zafra Gómez
2015-04-18  7:01     ` David Zafra Gómez
2015-04-26 21:54       ` David Zafra Gómez
2015-04-27 18:25         ` Benjamin Tissoires
2015-04-28  6:55           ` Hans de Goede
     [not found]             ` <553FFB10.6010005@klo.es>
2015-04-29  7:35               ` Hans de Goede
2015-04-30  5:34                 ` David Zafra Gómez
2015-04-30  8:38                   ` Hans de Goede [this message]
     [not found]                     ` <554A77AE.5030801@klo.es>
2015-05-06 20:33                       ` David Zafra Gómez
2015-05-18 10:19                       ` Hans de Goede
2015-05-27 20:35                         ` David Zafra Gómez
2015-05-28  9:10                           ` Hans de Goede
2015-05-28 14:55                             ` David Zafra Gómez
2015-05-28 14:56                               ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5541E9F1.5090902@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=dezeta@klo.es \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dusonlin@emc.com.tw \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.