From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508AbbECTSB (ORCPT ); Sun, 3 May 2015 15:18:01 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:35008 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbbECTRx (ORCPT ); Sun, 3 May 2015 15:17:53 -0400 Message-ID: <5546745D.4090109@gmail.com> Date: Sun, 03 May 2015 21:17:49 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Greg KH CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/21] staging: rtl8192e: replace memcpy() -> ether_addr_copy_unaligned() References: <1428961664-4241-1-git-send-email-mateusz.kulikowski@gmail.com> <1428961664-4241-11-git-send-email-mateusz.kulikowski@gmail.com> <20150503191033.GA12930@kroah.com> In-Reply-To: <20150503191033.GA12930@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03.05.2015 21:10, Greg KH wrote: > On Mon, Apr 13, 2015 at 11:47:33PM +0200, Mateusz Kulikowski wrote: >> rtl8192e driver uses memcpy() to copy hw addresses in several places. >> checkpatch.pl suggests to use ether_addr_copy(), but most of >> addresses in driver may be unaligned. >> This patch replaces all memcpy occurences with single macro therby >> silencing checkpatch.pl (single complaints in macro remains). >> >> Signed-off-by: Mateusz Kulikowski >> --- >> drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++--- >> drivers/staging/rtl8192e/rtllib.h | 3 ++ >> drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 18 +++---- >> drivers/staging/rtl8192e/rtllib_rx.c | 74 +++++++++++++++++----------- >> drivers/staging/rtl8192e/rtllib_softmac.c | 67 +++++++++++++------------ >> drivers/staging/rtl8192e/rtllib_softmac_wx.c | 5 +- >> drivers/staging/rtl8192e/rtllib_tx.c | 24 ++++----- >> 7 files changed, 113 insertions(+), 90 deletions(-) > > I've stopped applying here, no need to resend the first 9 of these > patches for your next round. Thanks, I was afraid you applied whole changeset by accident. I'm working on v3 (a bit slowly due to holidays/work) - hopefully will post it this/next week. Regards, Mateusz