From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbbEDHoG (ORCPT ); Mon, 4 May 2015 03:44:06 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:22555 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbbEDHnz (ORCPT ); Mon, 4 May 2015 03:43:55 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee691-f79ca6d00000456a-78-554723393876 Content-transfer-encoding: 8BIT Message-id: <55472339.8040408@samsung.com> Date: Mon, 04 May 2015 16:43:53 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Krzysztof Kozlowski Cc: Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD References: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> In-reply-to: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsWyRsSkUNdS2T3U4NtyVYvecyeZLK58fc9m 8eLeRRaL5/9+sFv0P37NbHG26Q27xabH11gtLu+aw2Yx4/w+JosZk1+yOXB57Jx1l91j06pO No/t3x6wetzvPs7ksXlJvUffllWMHp83yQWwR3HZpKTmZJalFunbJXBlrPrxl61gK3fF1G8H WRsYd3F2MXJySAiYSFy/e4cZwhaTuHBvPVsXIxeHkMBSRonjs24zwxRN/PKCCSIxnVHizOM7 7CAJXgFBiR+T77F0MXJwMAvISxy5lA0SZhZQl5g0bxFYr5DAfUaJ041OEOVaEmsfPGcDsVkE VCVuPbjKBGKzAdkTV9wHi4sKhEm8eLULrFdEwFBi+q6vzCB7mQUuMkl8b34AtldYwF3i/pUb LBAL3CSePV4BNogTKD570VFGkAYJga/sEnMP7IPaJiDxbfIhsEMlBGQlNh2AekxS4uCKGywT GMVmIXlnFsI7s5C8s4CReRWjaGpBckFxUnqRqV5xYm5xaV66XnJ+7iZGYJSe/vds4g7G+wes DzEKcDAq8fCeWOUWKsSaWFZcmXuI0RToiInMUqLJ+cBUkFcSb2hsZmRhamJqbGRuaaYkzqsj /TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+MOxsDahu7g7R82CLw4rPnnyAahlfZxgVuL vmv/at2dsShz5qsSnprX8v/8N76K25Z35NGvSe3HH3g9qFLblxW+xDlC/5rK/ILa05N15gfW W25Y/FP4z3Oex48CY5bOLsxZXv73+KFdMtzlnmydJ/J7nlXnC7Hmbp13qVTATmdVts8kmSIT HRElluKMREMt5qLiRAClY6oJzQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42I5/e+xoK6lsnuowd2FCha9504yWVz5+p7N 4sW9iywWz//9YLfof/ya2eJs0xt2i02Pr7FaXN41h81ixvl9TBYzJr9kc+Dy2DnrLrvHplWd bB7bvz1g9bjffZzJY/OSeo++LasYPT5vkgtgj2pgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443 NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBuk9JoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9I EFyPkQEaSFjDmLHqx1+2gq3cFVO/HWRtYNzF2cXIySEhYCIx8csLJghbTOLCvfVsXYxcHEIC 0xklzjy+ww6S4BUQlPgx+R5LFyMHB7OAvMSRS9kgYWYBdYlJ8xYxg9hCAvcZJU43OkGUa0ms ffCcDcRmEVCVuPXgKth8NiB74or7YHFRgTCJF692gfWKCBhKTN/1lRlkL7PARSaJ780PwPYK C7hL3L9ygwVigZvEs8crwAZxAsVnLzrKOIFRYBaS82YhnDcLyXkLGJlXMYqmFiQXFCel5xrp FSfmFpfmpesl5+duYgSngGfSOxhXNVgcYhTgYFTi4T2xyi1UiDWxrLgy9xCjBAezkgjvk49A Id6UxMqq1KL8+KLSnNTiQ4ymQN9NZJYSTc4Hpqe8knhDYxMzI0sjc0MLI2NzJXHeObpyoUIC 6YklqdmpqQWpRTB9TBycUg2MHbf7J55aNtP31MVsPicGLcntUu92p98+WWv+8IHO02mf2vl8 FvSIcvj9mCX+zVn19P6vKx9z//s8+VWfVXXTuZVT5i3bm3U/V/PTWldXVpE/3xdreZr1zfvX ZDebSzlHZWbyV461/PxXZaoLn/7btzhL+JmdU43oh6ezTWpqePce23rdIUwnTomlOCPRUIu5 qDgRACHmrhEXAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: > Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build > error: No, eDP has no any dependency of FIMD but DECON. Just add dependency code like below, config DRM_EXYNOS7_DECON bool "Exynos DRM DECON" - depends on DRM_EXYNOS + depends on DRM_EXYNOS && !FB_S3C > > drivers/built-in.o: In function `exynos_dp_dpms': > binder.c:(.text+0xd6a840): undefined reference to `fimd_dp_clock_enable' > binder.c:(.text+0xd6ab54): undefined reference to `fimd_dp_clock_enable' > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.h b/drivers/gpu/drm/exynos/exynos_drm_fimd.h > index b4fcaa568456..db67f3d9786d 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.h > @@ -10,6 +10,10 @@ > #ifndef _EXYNOS_DRM_FIMD_H_ > #define _EXYNOS_DRM_FIMD_H_ > > +#ifdef CONFIG_DRM_EXYNOS_FIMD > extern void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool enable); > +#else > +static inline void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool enable) {}; > +#endif So above codes are unnecessary. It's really not good to add #ifdef ~ #endif. Thanks, Inki Dae > > #endif /* _EXYNOS_DRM_FIMD_H_ */ > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD Date: Mon, 04 May 2015 16:43:53 +0900 Message-ID: <55472339.8040408@samsung.com> References: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNeuFhCAwNeyblCAwMuydvCAxMzowOCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiBTZWxlY3RpbmcgQ09ORklHX0ZCX1MzQyBkaXNhYmxlcyBDT05GSUdfRFJNX0VYWU5PU19GSU1E IGxlYWRpbmcgdG8gYnVpbGQKPiBlcnJvcjoKCk5vLCBlRFAgaGFzIG5vIGFueSBkZXBlbmRlbmN5 IG9mIEZJTUQgYnV0IERFQ09OLiBKdXN0IGFkZCBkZXBlbmRlbmN5CmNvZGUgbGlrZSBiZWxvdywK CiBjb25maWcgRFJNX0VYWU5PUzdfREVDT04KICAgICAgICBib29sICJFeHlub3MgRFJNIERFQ09O IgotICAgICAgIGRlcGVuZHMgb24gRFJNX0VYWU5PUworICAgICAgIGRlcGVuZHMgb24gRFJNX0VY WU5PUyAmJiAhRkJfUzNDCgo+IAo+IGRyaXZlcnMvYnVpbHQtaW4ubzogSW4gZnVuY3Rpb24gYGV4 eW5vc19kcF9kcG1zJzoKPiBiaW5kZXIuYzooLnRleHQrMHhkNmE4NDApOiB1bmRlZmluZWQgcmVm ZXJlbmNlIHRvIGBmaW1kX2RwX2Nsb2NrX2VuYWJsZScKPiBiaW5kZXIuYzooLnRleHQrMHhkNmFi NTQpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBmaW1kX2RwX2Nsb2NrX2VuYWJsZScKPiAKPiBT aWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgS296bG93c2tpIDxrLmtvemxvd3NraS5rQGdtYWlsLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2ZpbWQuaCB8IDQg KysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9maW1kLmggYi9kcml2ZXJzL2dwdS9k cm0vZXh5bm9zL2V4eW5vc19kcm1fZmltZC5oCj4gaW5kZXggYjRmY2FhNTY4NDU2Li5kYjY3ZjNk OTc4NmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2Zp bWQuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9maW1kLmgKPiBA QCAtMTAsNiArMTAsMTAgQEAKPiAgI2lmbmRlZiBfRVhZTk9TX0RSTV9GSU1EX0hfCj4gICNkZWZp bmUgX0VYWU5PU19EUk1fRklNRF9IXwo+ICAKPiArI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX0ZJ TUQKPiAgZXh0ZXJuIHZvaWQgZmltZF9kcF9jbG9ja19lbmFibGUoc3RydWN0IGV4eW5vc19kcm1f Y3J0YyAqY3J0YywgYm9vbCBlbmFibGUpOwo+ICsjZWxzZQo+ICtzdGF0aWMgaW5saW5lIHZvaWQg ZmltZF9kcF9jbG9ja19lbmFibGUoc3RydWN0IGV4eW5vc19kcm1fY3J0YyAqY3J0YywgYm9vbCBl bmFibGUpIHt9Owo+ICsjZW5kaWYKClNvIGFib3ZlIGNvZGVzIGFyZSB1bm5lY2Vzc2FyeS4gSXQn cyByZWFsbHkgbm90IGdvb2QgdG8gYWRkICNpZmRlZiB+ICNlbmRpZi4KClRoYW5rcywKSW5raSBE YWUKCj4gIAo+ICAjZW5kaWYgLyogX0VYWU5PU19EUk1fRklNRF9IXyAqLwo+IAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Mon, 04 May 2015 16:43:53 +0900 Subject: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD In-Reply-To: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> References: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> Message-ID: <55472339.8040408@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015? 05? 02? 13:08, Krzysztof Kozlowski wrote: > Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build > error: No, eDP has no any dependency of FIMD but DECON. Just add dependency code like below, config DRM_EXYNOS7_DECON bool "Exynos DRM DECON" - depends on DRM_EXYNOS + depends on DRM_EXYNOS && !FB_S3C > > drivers/built-in.o: In function `exynos_dp_dpms': > binder.c:(.text+0xd6a840): undefined reference to `fimd_dp_clock_enable' > binder.c:(.text+0xd6ab54): undefined reference to `fimd_dp_clock_enable' > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.h b/drivers/gpu/drm/exynos/exynos_drm_fimd.h > index b4fcaa568456..db67f3d9786d 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.h > @@ -10,6 +10,10 @@ > #ifndef _EXYNOS_DRM_FIMD_H_ > #define _EXYNOS_DRM_FIMD_H_ > > +#ifdef CONFIG_DRM_EXYNOS_FIMD > extern void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool enable); > +#else > +static inline void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool enable) {}; > +#endif So above codes are unnecessary. It's really not good to add #ifdef ~ #endif. Thanks, Inki Dae > > #endif /* _EXYNOS_DRM_FIMD_H_ */ >