From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: [PATCH kvm-unit-tests] x86: vmx: Remove bogus GUEST_RIP update from interrupt test Date: Mon, 04 May 2015 10:12:03 +0200 Message-ID: <554729D3.5060005@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit To: Paolo Bonzini , kvm Return-path: Received: from thoth.sbs.de ([192.35.17.2]:37105 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbbEDIML (ORCPT ); Mon, 4 May 2015 04:12:11 -0400 Sender: kvm-owner@vger.kernel.org List-ID: When we get an EXTINT exit, the guest RIP already points to the instruction after the one that sent it into HLT state. Moving the RIP based on stale insn_len caused spurious L2 crashes. Signed-off-by: Jan Kiszka --- x86/vmx_tests.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c index 4f8ace1..79552fd 100644 --- a/x86/vmx_tests.c +++ b/x86/vmx_tests.c @@ -1297,10 +1297,8 @@ static int interrupt_exit_handler(void) asm volatile ("nop"); irq_disable(); } - if (vmx_get_test_stage() >= 2) { + if (vmx_get_test_stage() >= 2) vmcs_write(GUEST_ACTV_STATE, ACTV_ACTIVE); - vmcs_write(GUEST_RIP, guest_rip + insn_len); - } return VMX_TEST_RESUME; default: printf("Unknown exit reason, %d\n", reason); -- 2.1.4