All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org,
	simon.kagstrom-vI6UBbBVNY+JA8cjQkG2/g@public.gmane.org
Subject: Re: [PATCH] scripts: fix relpath.sh output when build dir is a symlink
Date: Tue, 05 May 2015 11:00:56 +0200	[thread overview]
Message-ID: <554886C8.4090408@6wind.com> (raw)
In-Reply-To: <1430816409-6773-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Hi Simon,

On 05/05/2015 11:00 AM, Olivier Matz wrote:
> The script relpath.sh return the relative path of the first directory
> from the second directory. It is used to generate relative symlinks,
> which can be useful if the build directory is embedded in the dpdk
> directory: the whole dpdk can be moved without breaking the links,
> which is helpful for an installation.
>
> In case the build directory is a symlink, the script was not generating
> the proper relative path. Fix this by calling "readlink -f" on the
> arguments.
>
> Signed-off-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Can you have a try with this patch?

Regards,
Olivier

  parent reply	other threads:[~2015-05-05  9:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 12:42 build issue with out-of-tree builds and multiple mounts Simon Kågström
     [not found] ` <55476941.3030202-vI6UBbBVNY+JA8cjQkG2/g@public.gmane.org>
2015-05-04 12:48   ` Olivier MATZ
     [not found]     ` <55476A94.5000809-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-05-04 12:55       ` Simon Kågström
     [not found]         ` <55476C37.8050702-vI6UBbBVNY+JA8cjQkG2/g@public.gmane.org>
2015-05-05  9:00           ` [PATCH] scripts: fix relpath.sh output when build dir is a symlink Olivier Matz
     [not found]             ` <1430816409-6773-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-05-05  9:00               ` Olivier MATZ [this message]
     [not found]                 ` <554886C8.4090408-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-05-05  9:14                   ` Simon Kågström
2015-05-12 12:26                     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554886C8.4090408@6wind.com \
    --to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=simon.kagstrom-vI6UBbBVNY+JA8cjQkG2/g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.